8000 Removes \n or space when $context/$extra are empty by kirkmadera · Pull Request #24733 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Removes \n or space when $context/$extra are empty #24733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Removes \n or space when $context/$extra are empty #24733

wants to merge 3 commits into from

Conversation

kirkmadera
Copy link
Contributor
@kirkmadera kirkmadera commented Oct 29, 2017 •
edited
Loading

Simple log messages cause extra spaces or newlines when using the default format and $context or $extra are empty, resulting in output like this:

23:24:41 DEBUG     [test] debug


23:24:41 INFO      [test] info


23:24:41 NOTICE    [test] notice


23:24:41 WARNING   [test] warning


23:24:41 ERROR     [test] error

This makes reviewing command history difficult.

In the instance where $context or $extra is empty, it should not get appended with a space or newline.

Q A
Branch? 3.4 or master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT

@kirkmadera
Removes \n or space when $context/$extra are empty
fd167b7 
Simple log messages cause extra spaces or newlines when using the default format and $context or $extra are empty, resulting in output like this:

```
23:24:41 DEBUG     [test] debug


23:24:41 INFO      [test] info


23:24:41 NOTICE    [test] notice


23:24:41 WARNING   [test] warning


23:24:41 ERROR     [test] error


```

This makes reviewing command history difficult. 

In the instance where $context or $extra is empty, it should not get appended with a space or newline.
@kirkmadera
Copy link
Contributor Author

The labels attached to this ticket are invalid due to my initial commit message. This is a bugfix only.

@nicolas-grekas
Copy link
Member

Thanks and congrats for your first PR @kirkmadera
I think this bug exists in branch 3.3, so this should target 3.3
Please note also that the code style needs a fix, see fabbot.io line.

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Oct 30, 2017
@kirkmadera kirkmadera changed the base branch from master to 3.3 October 30, 2017 20:33
@kirkmadera kirkmadera changed the base branch from 3.3 to master October 30, 2017 20:38
@kirkmadera
Copy link
Contributor Author

Replaced with #24759 which branches from 3.3

@kirkmadera kirkmadera closed this Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@kirkmadera @nicolas-grekas @ogizanagi @carsonbot
0