[Bridge\Twig] Remove use of spaceless #24727
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkste
approved these changes
Oct 28, 2017
|
@arkste please make this patch yours :) |
|
@nicolas-grekas , this is because |
|
@vudaltsov yes, see linked comment |
fabpot
added a commit
that referenced
this pull request
Oct 30, 2017
…y & remove spaceless (arkste) This PR was squashed before being merged into the 3.4 branch (closes #24728). Discussion ---------- [Bridge\Twig] fix bootstrap checkbox_row to render properly & remove spaceless | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24711 | License | MIT | Doc PR | - As discussed in #24711 i reverted the change i did in `bootstrap_3_layout.html.twig` (which caused an unnecessary empty div-container in the vertical-layout), added the `checkbox_row` block to the `bootstrap_3_horizontal_layout.html.twig` and removed `spaceless` (as proposed in #24727). since i added `{#--#}` in bootstrap 3, i did the same for the same horizontal blocks in bootstrap 4 as well. I moved the `form_label_class` & `form_group_class` blocks to the top of `bootstrap_3_horizontal_layout.html.twig` & `bootstrap_4_horizontal_layout.html.twig`, this should improve DX as they were spreaded across the file. #24702 affected the bootstrap 4 horizontal layout as well, so i added the `checkbox_row` block to bootstrap 4 too. ping @fabpot @nicolas-grekas Commits ------- f84749f [Bridge\Twig] fix bootstrap checkbox_row to render properly & remove spaceless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @fabpot @arkste