Remove useless docblocks #24724
Remove useless docblocks #24724
Conversation
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
a78be0c to
86fbc09
Compare
68b6ebf to
64437a3
Compare
| @@ -23,29 +23,10 @@ | |||
| */ | |||
| class DoctrineChoiceLoader implements ChoiceLoaderInterface | |||
| { | |||
| /** | |||
| * @var ChoiceListFactoryInterface | |||
There was a problem hiding this comment.
phpstorm requires those annotations for autocomplete AFAIK
There was a problem hiding this comment.
Phpstorm doesn't need them when the type is inferable from the constructor.
64437a3 to
2443511
Compare
| @@ -178,7 +178,7 @@ protected function getChainDriverServiceName(ContainerBuilder $container) | |||
| /** | |||
| * Create the service definition for the metadata driver. | |||
| * | |||
| * @param ContainerBuilder $container passed on in case an extending class | |||
| * @param ContainerBuilder $container Passed on in case an extending class | |||
There was a problem hiding this comment.
such changes should probably be reverted as #24149 added a cs rule against doing sentences in phpdoc (no uppercase, no ending dot)
There was a problem hiding this comment.
I don't understand the reasoning given there.
In fact, having an uppercase letter makes the docblock easier to read as the eyes more obviously can spot when a new column starts.
The code base is also using uppercase everywhere else. This is not by chance, but because it is most natural to others.
In short, this is something I did on purpose.
There was a problem hiding this comment.
And I fully agree, we just did the contrary when merging it.
This PR was merged into the 2.7 branch. Discussion ---------- Remove useless docblocks | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 2443511 Remove useless docblocks