8000 [WebProfilerBundle] Show the kernel class in the profiler instead of the kernel name by javiereguiluz · Pull Request #24717 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[WebProfilerBundle] Show the kernel class in the profiler instead of the kernel name #24717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WebProfilerBundle] Show the kernel class in the profiler instead of the kernel name #24717

wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

In my opinion, displaying the "kernel FQCN" is more useful than the "kernel name" for modern Symfony versions. This PR tries to do that and it'd look as follows:

kernel-class-1

kernel-class-2

@javiereguiluz javiereguiluz added this to the 4.1 milestone Oct 28, 2017
@ro0NL
Copy link
Contributor
ro0NL commented Oct 28, 2017

Well.. both have its purpose =/ From #24292 i dont think we should drop/hide kernel name here. IMHO 'name' has more value then 'class' actually.

Also from bin/console about we call this Kernel type and Kernel name, so either one needs an update IMHO :) (CLI also displays both values).

What about <span title="Kernel type">Kernel name</span> here?

@javiereguiluz
Copy link
Member Author

Closing because this proposal didn't gain any traction. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @ro0NL @carsonbot
0