8000 Add "doctrine/annotations" to top-level composer.json by siwinski · Pull Request #24658 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

Add "doctrine/annotations" to top-level composer.json #24658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

siwinski
Copy link
Contributor
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Adding to top-level composer.json as require-dev since it is already dev-required by the following:

  • src/Symfony/Bundle/FrameworkBundle/composer.json: "doctrine/annotations": "~1.0"
  • src/Symfony/Bundle/TwigBundle/composer.json: "doctrine/annotations": "~1.0"
  • src/Symfony/Component/PropertyInfo/composer.json: "doctrine/annotations": "~1.0"
  • src/Symfony/Component/Routing/composer.json: "doctrine/annotations": "~1.0",
  • src/Symfony/Component/Serializer/composer.json: "doctrine/annotations": "~1.0",
  • src/Symfony/Component/Validator/composer.json: "doctrine/annotations": "~1.0",

Adding to top-level composer.json as require-dev since it is already dev-required by the following:

* src/Symfony/Bundle/FrameworkBundle/composer.json:        "doctrine/annotations": "~1.0"
* src/Symfony/Bundle/TwigBundle/composer.json:        "doctrine/annotations": "~1.0"
* src/Symfony/Component/PropertyInfo/composer.json:        "doctrine/annotations": "~1.0"
* src/Symfony/Component/Routing/composer.json:        "doctrine/annotations": "~1.0",
* src/Symfony/Component/Serializer/composer.json:        "doctrine/annotations": "~1.0",
* src/Symfony/Component/Validator/composer.json:        "doctrine/annotations": "~1.0",
@siwinski siwinski force-pushed the pr-add-doctrine-annotations-to-top-level-composer-json branch from 68b0b1d to 3cdf4eb Compare October 21, 2017 20:33
@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Oct 23, 2017
@nicolas-grekas
Copy link
Member

Thank you @siwinski.

@nicolas-grekas nicolas-grekas merged commit 3cdf4eb into symfony:2.7 Oct 24, 2017
nicolas-grekas added a commit that referenced this pull request Oct 24, 2017
…iwinski)

This PR was merged into the 2.7 branch.

Discussion
----------

Add "doctrine/annotations" to top-level composer.json

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Adding to top-level composer.json as require-dev since it is already dev-required by the following:

* `src/Symfony/Bundle/FrameworkBundle/composer.json`:        `"doctrine/annotations": "~1.0"`
* `src/Symfony/Bundle/TwigBundle/composer.json`:        `"doctrine/annotations": "~1.0"`
* `src/Symfony/Component/PropertyInfo/composer.json`:        `"doctrine/annotations": "~1.0"`
* `src/Symfony/Component/Routing/composer.json`:        `"doctrine/annotations": "~1.0",`
* `src/Symfony/Component/Serializer/composer.json`:        `"doctrine/annotations": "~1.0",`
* `src/Symfony/Component/Validator/composer.json`:        `"doctrine/annotations": "~1.0",`

Commits
-------

3cdf4eb Add "doctrine/annotations" to top-level composer.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0