[HttpFoundation] Make sessions secure and lazy #24523
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F438
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,165 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Symfony package. | ||
| * | ||
| * (c) Fabien Potencier <fabien@symfony.com> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| namespace Symfony\Component\HttpFoundation\Session\Storage\Handler; | ||
|
|
||
| /** | ||
| * This abstract session handler provides a generic implementation | ||
| * of the PHP 7.0 SessionUpdateTimestampHandlerInterface, | ||
| * enabling strict and lazy session handling. | ||
| * | ||
| * @author Nicolas Grekas <p@tchwork.com> | ||
| */ | ||
| abstract class AbstractSessionHandler implements \SessionHandlerInterface, \SessionUpdateTimestampHandlerInterface | ||
| { | ||
| private $sessionName; | ||
| private $prefetchId; | ||
| private $prefetchData; | ||
| private $newSessionId; | ||
| private $igbinaryEmptyData; | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function open($savePath, $sessionName) | ||
| { | ||
| $this->sessionName = $sessionName; | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
| /** | ||
| * @param string $sessionId | ||
| * | ||
| * @return string | ||
| */ | ||
| abstract protected function doRead($sessionId); | ||
|
|
||
| /** | ||
| * @param string $sessionId | ||
| * @param string $data | ||
| * | ||
| * @return bool | ||
| */ | ||
| abstract protected function doWrite($sessionId, $data); | ||
|
|
||
| /** | ||
| * @param string $sessionId | ||
| * | ||
| * @return bool | ||
| */ | ||
| abstract protected function doDestroy($sessionId); | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function validateId($sessionId) | ||
| { | ||
| $this->prefetchData = $this->read($sessionId); | ||
| $this->prefetchId = $sessionId; | ||
|
|
||
| return '' !== $this->prefetchData; | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
|
There was a problem hiding this comment. i thought we don't add inheritdoc anymore which seems useless. There was a problem hiding this comment. that was asked for, but rejected AFAIK |
||
| */ | ||
| public function read($sessionId) | ||
| { | ||
| if (null !== $this->prefetchId) { | ||
| $prefetchId = $this->prefetchId; | ||
| $prefetchData = $this->prefetchData; | ||
| $this->prefetchId = $this->prefetchData = null; | ||
|
|
||
| if ($prefetchId === $sessionId || '' === $prefetchData) { | ||
| $this->newSessionId = '' === $prefetchData ? $sessionId : null; | ||
|
|
||
| return $prefetchData; | ||
| } | ||
| } | ||
|
|
||
| $data = $this->doRead($sessionId); | ||
| $this->newSessionId = '' === $data ? $sessionId : null; | ||
| if (\PHP_VERSION_ID < 70000) { | ||
| $this->prefetchData = $data; | ||
| } | ||
|
|
||
| return $data; | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function write($sessionId, $data) | ||
| { | ||
| if (\PHP_VERSION_ID < 70000 && $this->prefetchData) { | ||
| $readData = $this->prefetchData; | ||
| $this->prefetchData = null; | ||
|
|
||
| if ($readData === $data) { | ||
| return $this->updateTimestamp($sessionId, $data); | ||
| } | ||
| } | ||
| if (null === $this->igbinaryEmptyData) { | ||
| // see https://github.com/igbinary/igbinary/issues/146 | ||
| $this->igbinaryEmptyData = \function_exists('igbinary_serialize') ? igbinary_serialize(array()) : ''; | ||
| } | ||
| if ('' === $data || $this->igbinaryEmptyData === $data) { | ||
| return $this->destroy($sessionId); | ||
| } | ||
| $this->newSessionId = null; | ||
|
|
||
| return $this->doWrite($sessionId, $data); | ||
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function destroy($sessionId) | ||
| { | ||
| if (\PHP_VERSION_ID < 70000) { | ||
| $this->prefetchData = null; | ||
| } | ||
| if (!headers_sent() && ini_get('session.use_cookies')) { | ||
| if (!$this->sessionName) { | ||
| throw new \LogicException(sprintf('Session name cannot be empty, did you forget to call "parent::open()" in "%s"?.', get_class($this))); | ||
| } | ||
| $sessionCookie = sprintf(' %s=', urlencode($this->sessionName)); | ||
| $sessionCookieWithId = sprintf('%s%s;', $sessionCookie, urlencode($sessionId)); | ||
| $sessionCookieFound = false; | ||
| $otherCookies = array(); | ||
| foreach (headers_list() as $h) { | ||
| if (0 !== stripos($h, 'Set-Cookie:')) { | ||
| continue; | ||
| } | ||
| if (11 === strpos($h, $sessionCookie, 11)) { | ||
| $sessionCookieFound = true; | ||
|
|
||
| if (11 !== strpos($h, $sessionCookieWithId, 11)) { | ||
| $otherCookies[] = $h; | ||
| } | ||
| } else { | ||
| $otherCookies[] = $h; | ||
| } | ||
| } | ||
| if ($sessionCookieFound) { | ||
| header_remove('Set-Cookie'); | ||
| foreach ($otherCookies as $h) { | ||
| header('Set-Cookie:'.$h, false); | ||
| } | ||
| } else { | ||
| setcookie($this->sessionName, '', 0, ini_get('session.cookie_path'), ini_get('session.cookie_domain'), ini_get('session.cookie_secure'), ini_get('session.cookie_httponly')); | ||
| } | ||
| } | ||
|
|
||
| return $this->newSessionId === $sessionId || $this->doDestroy($sessionId); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those or no alternative for WriteCheckSessionHandler. only session.lazy_write option is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
session.lazy_writerequiresupdateTimestamp(), thusSessionUpdateTimestampHandlerInterface