fix PHP 7.2 compatibility #24509
Merged
fix PHP 7.2 compatibility #24509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
stof
approved these changes
Oct 10, 2017
b022892 to
c1e8131
Compare
chalasr
approved these changes
Oct 10, 2017
javiereguiluz
approved these changes
Oct 10, 2017
Simperfit
approved these changes
Oct 10, 2017
* the `phpdocumentor/type-resolver` package was not PHP 7.2 compatible before release 0.2.1 (see see phpDocumentor/TypeResolver@e224fb2) * the validator must not call `get_class()` if no object but a class name was passed to the `validatePropertyValue()` method
c1e8131 to
2d2022c
Compare
xabbuh
added a commit
that referenced
this pull request
Oct 10, 2017
This PR was merged into the 3.3 branch. Discussion ---------- fix PHP 7.2 compatibility | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | * the `phpdocumentor/type-resolver` package was not PHP 7.2 compatible before release 0.2.1 (see see phpDocumentor/TypeResolver@e224fb2) * the validator must not call `get_class()` if no object but a class name was passed to the `validatePropertyValue()` method Commits ------- 2d2022c fix PHP 7.2 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpdocumentor/type-resolverpackage was not PHP 7.2 compatiblebefore release 0.2.1 (see see phpDocumentor/TypeResolver@e224fb2)
get_class()if no object but a classname was passed to the
validatePropertyValue()method