8000 [PHPUnitBridge] don't remove when set to empty string by Simperfit · Pull Request #24379 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[PHPUnitBridge] don't remove when set to empty string #24379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Simperfit
Copy link
Contributor
Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23955
License MIT
Doc PR

Fix a bug when passing empty string symfony/yaml and phpspec/prophecy

@fabpot
Copy link
Member
fabpot commented Sep 30, 2017

Thank you @Simperfit.

@fabpot fabpot merged commit 722872f into symfony:3.3 Sep 30, 2017
fabpot added a commit that referenced this pull request Sep 30, 2017
…perfit)

This PR was merged into the 3.3 branch.

Discussion
----------

[PHPUnitBridge] don't remove when set to  empty string

| Q             | A
| ------------- | ---
| Branch?       |3.3
| Bug fix?      | yes
| New feature?  |no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23955
| License       | MIT
| Doc PR        |

Fix a bug when passing empty string symfony/yaml and phpspec/prophecy

Commits
-------

722872f [PHPUnitBridge] don't remove when set to  empty string
@fabpot fabpot mentioned this pull request Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0