[TwigBundle] register an identity translator as fallback #24358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Form component can be used without the Translation component. However, to be able to use the default form themes provided by the TwigBridge you need to have the `trans` filter to be available. This change ensure that there will always be a `trans` filter which as a fallback will just return the message key if no translator is present.
|
#24303 already improved the situation when running |
ogizanagi
approved these changes
Sep 28, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Sep 28, 2017
…ck (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [TwigBundle] register an identity translator as fallback | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24303 (comment) | License | MIT | Doc PR | The Form component can be used without the Translation component. However, to be able to use the default form themes provided by the TwigBridge you need to have the `trans` filter to be available. This change ensure that there will always be a `trans` filter which as a fallback will just return the message key if no translator is present. Commits ------- f0876e5 register an identity translator as fallback
stof
reviewed
Sep 28, 2017
| @@ -94,11 +94,19 @@ public function getTranslationNodeVisitor() | |||
|
|
|||
| public function trans($message, array $arguments = array(), $domain = null, $locale = null) | |||
| { | |||
| if (null === $this->translator) { | |||
| return $message; | |||
There was a problem hiding this comment.
we should still replace arguments IMO. Otherwise this does not work even for the case where the English message is the source
fabpot
added a commit
that referenced
this pull request
Oct 12, 2017
…or (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [TwigBridge] replace parameters in dummy identity translator | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24358 (comment) | License | MIT | Doc PR | Commits ------- 2c9c3d8 replace parameters in dummy identity translator
This was referenced Oct 18, 2017
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Nov 7, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Bridge\Twig] Lazy-load deps | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted while benching a HelloWorld and comparing v3.3 to v4.0. At this micro-bench level, even registering one more twig extension makes a difference (here, it's `TranslationExtension`, after #24358) Commits ------- 3fc766f [Bridge\Twig] Lazy-load deps
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Sep 21, 2018
…allback (yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Register an identity translator as fallback | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27589 | License | MIT | Doc PR | - The same approach as symfony/symfony#24358, suggested by @xabbuh here symfony/symfony#27589 (comment) **Templating Engine Context** The Form component can be used without the Translation component. However, to be able to use the default form themes provided by the `FrameworkBundle` you need to have the `translator` helper to be available. This change ensure that there will always be a `translator` helper which as a fallback will just return the message key if no translator is present. Commits ------- 5330f2d017 [FrameworkBundle] Register an identity translator as fallback
nicolas-grekas
added a commit
that referenced
this pull request
Sep 21, 2018
…allback (yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Register an identity translator as fallback | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27589 | License | MIT | Doc PR | - The same approach as #24358, suggested by @xabbuh here #27589 (comment) **Templating Engine Context** The Form component can be used without the Translation component. However, to be able to use the default form themes provided by the `FrameworkBundle` you need to have the `translator` helper to be available. This change ensure that there will always be a `translator` helper which as a fallback will just return the message key if no translator is present. Commits ------- 5330f2d [FrameworkBundle] Register an identity translator as fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Form component can be used without the Translation component.
However, to be able to use the default form themes provided by the
TwigBridge you need to have the
transfilter to be available.This change ensures that there will always be a
transfilter which asa fallback will just return the message key if no translator is present.