8000 [HttpKernel][FrameworkBundle] Add a minimalist default PSR-3 logger by dunglas · Pull Request #24300 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel][FrameworkBundle] Add a minimalist default PSR-3 logger #24300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[HttpKernel][FrameworkBundle] Add a minimalist default PSR-3 logger #24300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5713142
[HttpKernel][FrameworkBundle] Add a minimalist default PSR-3 logger
dunglas Sep 23, 2017
9dde784
Remove final and @internal. Change pass priority.
dunglas Sep 28, 2017
87df1f1
Add @param. Change pass priority
dunglas Sep 28, 2017
e5e9eb8
Fix tests
dunglas Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add @param. Change pass priority
  • Loading branch information
@dunglas
dunglas committed Sep 28, 2017
commit 87df1f1ce141cf1c2f243d6d757ac92bdc7c4a29
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function build(ContainerBuilder $container)
{
parent::build($container);

$container->addCompilerPass(new LoggerPass());
$container->addCompilerPass(new LoggerPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, -32);
$container->addCompilerPass(new RegisterControllerArgumentLocatorsPass());
$container->addCompilerPass(new RemoveEmptyControllerArgumentLocatorsPass(), PassConfig::TYPE_BEFORE_REMOVING);
$container->addCompilerPass(new RoutingResolverPass());
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/HttpKernel/Log/Logger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public function log($level, $message, array $context = array())
/**
* @param string $level
* @param string $message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing $context

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On purpose, the type is already documented by the typehint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I did so on some of my PRs, stof told me we don't do partial doc blocks :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we ma also remove the docblock entirely :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other types aren't inferable.

* @param array $context
*
* @return string
*/
Expand Down
0