[FrameworkBundle] Reset stopwatch between requests #24193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $container->register('debug.stopwatch', Stopwatch::class) | ||
| ->addArgument(true) | ||
| ->setPrivate(true) | ||
| ->addTag('kernel.reset', array('method' => 'reset')); |
There was a problem hiding this comment.
the method exists since 3.4, so I think we should raise the dep in composer.json
1871164 to
7c3bdd9
Compare
nicolas-grekas
approved these changes
Sep 14, 2017
xabbuh
approved these changes
Sep 15, 2017
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 15, 2017
…rrabus) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Reset stopwatch between requests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23984 | License | MIT | Doc PR | N/A Follow-up to #24155. This PR ensures that the stopwatch is reset between requests. Commits ------- 7c3bdd9 Reset stopwatch.
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #24155. This PR ensures that the stopwatch is reset between requests.