[FrameworkBundle] Enable assets with templates only if the Asset component is installed #24172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR | - |
…onent is installed
|
could it make sense to merge this in 3.3? |
Taluu
reviewed
Sep 17, 2017
| @@ -52,7 +52,7 @@ public function getConfigTreeBuilder() | |||
|
|
|||
| $rootNode | |||
| ->beforeNormalization() | |||
| ->ifTrue(function ($v) { return !isset($v['assets']) && isset($v['templating']); }) | |||
| ->ifTrue(function ($v) { return !isset($v['assets']) && isset($v['templating']) && class_exists(Package::class); }) | |||
There was a problem hiding this comment.
How about moving the class check at the start of the condition ? (Yes that's kind of a micro-optimization...)
There was a problem hiding this comment.
calling a function last is the best it terms of µoptim to me
nicolas-grekas
approved these changes
Sep 26, 2017
fabpot
approved these changes
Sep 27, 2017
|
Thank you @hason. |
fabpot
added a commit
that referenced
this pull request
Sep 27, 2017
…he Asset component is installed (hason) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Enable assets with templates only if the Asset component is installed | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | - Commits ------- 5bc0b05 [FrameworkBundle] Enable assets with templates only if the Asset component is installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.