8000 [CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction by SpacePossum · Pull Request #24123 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction #24123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction #24123

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbc51fe
no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_i…
SpacePossum Sep 7, 2017
f65fd69
yoda_style
SpacePossum Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_i… 
…nstruction
  • Loading branch information
@SpacePossum @nicolas-grekas
SpacePossum authored and nicolas-grekas committed Sep 15, 2017
commit fbc51fe7a9b252ca0c8afcb8ecac65f16df891c3
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/Resources/views/FormTable/button_row.html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<tr>
<td></td>
<td>
<?php echo $view['form']->widget($form) ?>
<?php echo $view['form']->widget($form); ?>
</td>
</tr>
6 changes: 3 additions & 3 deletions src/Symfony/Bundle/FrameworkBundle/Resources/views/FormTable/form_row.html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<tr>
<td>
<?php echo $view['form']->label($form) ?>
<?php echo $view['form']->label($form); ?>
</td>
<td>
<?php echo $view['form']->errors($form) ?>
<?php echo $view['form']->widget($form) ?>
<?php echo $view['form']->errors($form); ?>
<?php echo $view['form']->widget($form); ?>
</td>
</tr>
10 changes: 5 additions & 5 deletions src/Symfony/Bundle/FrameworkBundle/Resources/views/FormTable/form_widget_compound.html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<table <?php echo $view['form']->block($form, 'widget_container_attributes') ?>>
<table <?php echo $view['form']->block($form, 'widget_container_attributes'); ?>>
<?php if (!$form->parent && $errors): ?>
<tr>
<td colspan="2">
<?php echo $view['form']->errors($form) ?>
<?php echo $view['form']->errors($form); ?>
</td>
</tr>
<?php endif ?>
<?php echo $view['form']->block($form, 'form_rows') ?>
<?php echo $view['form']->rest($form) ?>
<?php endif; ?>
<?php echo $view['form']->block($form, 'form_rows'); ?>
<?php echo $view['form']->rest($form); ?>
</table>
2 changes: 1 addition & 1 deletion src/Symfony/Bundle/FrameworkBundle/Resources/views/FormTable/hidden_row.html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<tr style="display: none">
<td colspan="2">
<?php echo $view['form']->widget($form) ?>
<?php echo $view['form']->widget($form); ?>
</td>
</tr>
2 changes: 1 addition & 1 deletion ...ymfony/Bundle/FrameworkBundle/Tests/Templating/Helper/Resources/Child/form_label.html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<label><?php echo $global ?>child</label>
<label><?php echo $global; ?>child</label>
4 changes: 2 additions & 2 deletions ...ndle/FrameworkBundle/Tests/Templating/Helper/Resources/Parent/form_widget_simple.html.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?php $type = isset($type) ? $type : 'text' ?>
<input type="<?php echo $type ?>" <?php $view['form']->block($form, 'widget_attributes') ?> value="<?php echo $value ?>" rel="theme" />
<?php $type = isset($type) ? $type : 'text'; ?>
<input type="<?php echo $type; ?>" <?php $view['form']->block($form, 'widget_attributes'); ?> value="<?php echo $value; ?>" rel="theme" />
0