8000 Deprecated the web_profiler.position option by javiereguiluz · Pull Request #24080 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Deprecated the web_profiler.position option #24080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Deprecated the web_profiler.position option #24080

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1316e98
Deprecated the web_profiler.position option
javiereguiluz Sep 3, 2017
f2db295
Added the missing entry in the CHANGELOG
javiereguiluz Sep 3, 2017
1a32a73
Use the new setDeprecated() method
javiereguiluz Sep 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Deprecated the web_profiler.position option
  • Loading branch information
@javiereguiluz
javiereguiluz committed Sep 3, 2017
commit 1316e98b893247fd33e3118d194725e776ede44f
6 changes: 6 additions & 0 deletions src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ public function getConfigTreeBuilder()
->booleanNode('toolbar')->defaultFalse()->end()
->scalarNode('position')
->defaultValue('bottom')
->beforeNormalization()
->ifTrue(function ($v) { return null !== $v; })
->then(function () {
@trigger_error('The "web_profiler.position" configuration key has been deprecated in Symfony 3.4 and it will be removed in 4.0.', E_USER_DEPRECATED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now use setDeprecated() instead, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiereguiluz Can you make the change?

})
->end()
->validate()
->ifNotInArray(array('bottom', 'top'))
->thenInvalid('The CSS position %s is not supported')
Expand Down
0