[HttpKernel] Dont register env parameter resource #24067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Sep 1, 2017
chalasr
approved these changes
Sep 1, 2017
|
have some patience :) done. |
|
Deprecation can be done in 3.4, let me know if you want a PR. |
|
I suggest deprecating EnvParametersResource in 3.4, in favor of env placeholders. The implementation of this resource is tied to the old logic reading magic env variables. It is not a generic resource for env variable usage anyway, so using it in other contexts that HttpKernel would be weird. |
|
Basically it's a resource to verify freshness of any env var, tied to a prefix. i think it fits config component, it's generic enough for that imo, but im not sure it be useful to anyone =/ |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 3, 2017
This PR was squashed before being merged into the 3.4 branch (closes #24068). Discussion ---------- [HttpKernel] Deprecate EnvParametersResource | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> See #24067 Commits ------- 76ea6df [HttpKernel] Deprecate EnvParametersResource
|
#24068 is now merged up to master, can you rebase and remove the deprecated class meanwhile please? |
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 5, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [HttpKernel] Dont register env parameter resource | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Think this was forgotten in #22886 Not sure about `EnvParametersResource` in the http-kernel component. Core doesnt use it anymore, so we could deprecate it (and while doing so move it to config component to keep the feature if wanted). Kept as is for now. Commits ------- 36d2a45 [HttpKernel] Dont register env parameter resource
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Think this was forgotten in #22886
Not sure about
EnvParametersResourcein the http-kernel component. Core doesnt use it anymore, so we could deprecate it (and while doing so move it to config component to keep the feature if wanted). Kept as is for now.