8000 [VarDumper] Fix interval caster with microseconds by maidmaid · Pull Request #24055 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarDumper] Fix interval caster with microseconds #24055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[VarDumper] Fix interval caster with microseconds #24055

wants to merge 1 commit into from

Conversation

maidmaid
Copy link
Contributor
@maidmaid maidmaid commented Aug 31, 2017 •
edited
Loading
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets /
License MIT
Doc PR / 
dump((new DateTime('00:00:00'))->diff(new DateTime('00:00:00.123')));

// before
DateInterval {
  interval: + 00:00:00.0.123
}

// after
DateInterval {
  interval: + 00:00:00.123
}

maidmaid
maidmaid commented Aug 31, 2017
View reviewed changes
src/Symfony/Component/VarDumper/Tests/Caster/DateCasterTest.php
array('P1DT24H', 1, '- 2d', null),
array('P1M32D', 1, '- 1m 32d', null),
array('PT0S', 0, 0, '0s', '0s'),
array('PT0S', 0.1, 0, '+ 00:00:00'.$ms1, '0s'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here the added test.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 31, 2017
@nicolas-grekas
Copy link
Member

can you please merge that PR with #24030?
please group PRs as much as possible, each PRs adds its own process overhead...

@maidmaid
Copy link
Contributor Author

That's 2 different things to me: this PR is a bug in interval caster and #24030 is a feature in period caster.

@nicolas-grekas
Copy link
Member

but both conflict, isn't it? so they do relate :)
and since this is 3.4 only, we don't really care having a dedicated line in the changelog either.

@maidmaid
Copy link
Contributor Author

Ok, I can understand that it makes your life easier. I'll merge both PRs asap :)

@nicolas-grekas
Copy link
Member
8000

thanks on behalf of the core team ;)

@maidmaid
Copy link
Contributor Author

As requested, PR merged in #24030.

@maidmaid maidmaid closed this Aug 31, 2017
@maidmaid maidmaid deleted the vardumper-interval-fix branch September 4, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review VarDumper
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@maidmaid @nicolas-grekas @carsonbot
0