8000 [travis] Add timing info by nicolas-grekas · Pull Request #23972 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[travis] Add timing info #23972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2017
Merged

[travis] Add timing info #23972

merged 1 commit into from
Aug 25, 2017

Conversation

nicolas-grekas
Copy link
Member
@nicolas-grekas nicolas-grekas commented Aug 24, 2017 •
edited
Loading
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Let's see if this works.
For reference, see https://github.com/travis-ci/travis-build/blob/master/lib/travis/build/templates/header.sh

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Aug 24, 2017
@nicolas-grekas nicolas-grekas force-pushed the travis-timing branch 3 times, most recently from 9d87e46 to be98d38 Compare August 24, 2017 08:53
sstok
sstok reviewed Aug 24, 2017
View reviewed changes
.travis.yml
local os=$(uname)
if hash gdate > /dev/null 2>&1; then
cmd="gdate"
elif [[ "$os" = Darwin ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't test on macOS (yet) right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I just borrowed this code from elsewhere

@stof
Copy link
Member
stof commented Aug 24, 2017

the output is weird. the timing gets on a next line. This may not be the right ordering.

@nicolas-grekas nicolas-grekas force-pushed the travis-timing branch 5 times, most recently from f2b7a78 to 7abefe5 Compare August 24, 2017 11:06
@nicolas-grekas
Copy link
Member Author

Works great!

capture du 2017-08-24 13-18-09

@nicolas-grekas nicolas-grekas merged commit 51d210e into symfony:2.7 Aug 25, 2017
nicolas-grekas added a commit that referenced this pull request Aug 25, 2017
@nicolas-grekas
minor #23972 [travis] Add timing info (nicolas-grekas)
3ba4112 
This PR was merged into the 2.7 branch.

Discussion
----------

[travis] Add timing info

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Let's see if this works.
For reference, see https://github.com/travis-ci/travis-build/blob/master/lib/travis/build/templates/header.sh

Commits
-------

51d210e [travis] Add timing info
@nicolas-grekas nicolas-grekas deleted the travis-timing branch August 25, 2017 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstok sstok sstok left review comments

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @stof @sstok @carsonbot
0