-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Tests for EntityType field with multiple=true #23930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
1951 commits
Select commit
Hold shift + click to select a range
7efb4f0
Minor typo fix messsagesData -> messagesData
jverdeyen 2fee5bc
minor #21645 Minor typo fix messsagesData -> messagesData (jverdeyen)
fabpot 6f578ee
[DI] Bug in autowiring collisions detection
nicolas-grekas 33bae93
Merge branch '2.7' into 2.8
nicolas-grekas 3348879
Merge branch '2.7' into 2.8
nicolas-grekas bb629f3
Merge branch '2.7' into 2.8
nicolas-grekas f2baf91
Merge branch '2.7' into 2.8
fabpot 0e1596d
fixed Composer constraints
fabpot bb70472
[DependencyInjection] Fix autowiring collisions detection
GuilhemN 5981278
[DependencyInjection] Fix using autowiring types when there are more …
GuilhemN 3cfd04b
bug #21665 [DependencyInjection] Fix autowiring collisions detection …
fabpot 3f5c0b1
bug #21670 [DependencyInjection] Fix autowiring types when there are …
fabpot 3616d5e
Merge branch '2.7' into 2.8
fabpot 205ced4
Updated PHPUnit namespaces
peterrehm f2754eb
minor #21663 Updated PHPUnit namespaces (peterrehm)
nicolas-grekas f9f53b2
Merge branch '2.7' into 2.8
nicolas-grekas 1337cdb
[WebServerBundle] fixed html attribute escape
Seb33300 13fff76
Merge branch '2.7' into 2.8
nicolas-grekas dbe8898
Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
peterrehm f6893c7
minor #21695 Refactored other PHPUnit method calls to work with names…
nicolas-grekas 5db127b
Merge branch '2.7' into 2.8
nicolas-grekas 4584fad
fix deps
nicolas-grekas 8201e47
Merge branch '2.7' into 2.8
fabpot de95fd5
Merge branch '2.7' into 2.8
fabpot 57a81eb
bug #21689 [WebServerBundle] fixed html attribute escape (Seb33300)
javiereguiluz cee435f
do not register the test listener twice
xabbuh d5d68c0
bug #21787 [PhpUnitBridge] do not register the test listener twice (x…
fabpot 4d4dec3
Merge branch '2.7' into 2.8
fabpot 15106bf
Merge branch '2.7' into 2.8
nicolas-grekas 8881221
Merge branch '2.7' into 2.8
nicolas-grekas cb14bfd
[2.8] Fix issues reported by static analyse
romainneutron d8c964c
minor #21801 [2.8] Fix issues reported by static analyse (romainneutron)
nicolas-grekas 2d174f2
Merge branch '2.7' into 2.8
fabpot 4b27628
fixed tests
fabpot e068661
disable global test listener when not registered
xabbuh cadc313
bug #21825 [PhpUnitBridge] disable global test listener when not regi…
fabpot db38c6f
Merge branch '2.7' into 2.8
fabpot a19e3fe
Merge branch '2.7' into 2.8
fabpot c8d364b
[Console] Do not squash input changes made from console.command event
chalasr 6e9d1bb
Merge branch '2.7' into 2.8
nicolas-grekas 663661b
Merge branch '2.7' into 2.8
fabpot 8279055
Merge branch '2.7' into 2.8
fabpot b8b6774
bug #21841 [Console] Do not squash input changes made from console.co…
fabpot cf8a7d2
updated CHANGELOG for 2.8.18
fabpot f32f6ce
updated VERSION for 2.8.18
fabpot 8c28bf7
Merge pull request #21885 from fabpot/release-2.8.18
fabpot 07dfac3
bumped Symfony version to 2.8.19
fabpot 2a7e385
Merge branch '2.7' into 2.8
fabpot 6568a76
Merge branch '2.7' into 2.8
nicolas-grekas d59c9c7
Merge branch '2.7' into 2.8
nicolas-grekas 25a2ce0
Merge branch '2.7' into 2.8
fabpot 870c26f
[VarDumper] Add missing isset() checks in some casters
nicolas-grekas d1cadf0
bug #21976 [VarDumper] Add missing isset() checks in some casters (ni…
nicolas-grekas 3c37037
Merge branch '2.7' into 2.8
fabpot 9fb17b4
Merge branch '2.7' into 2.8
nicolas-grekas 6b4cfd6
Merge branch '2.7' into 2.8
nicolas-grekas 5af47c4
Revert "bug #21841 [Console] Do not squash input changes made from co…
chalasr 58b3ee7
[DI] Fix PhpDumper generated doc block
nicolas-grekas 5d06aca
Merge branch '2.7' into 2.8
nicolas-grekas 5dd83ad
minor #22065 [DI] Fix PhpDumper generated doc block (nicolas-grekas)
nicolas-grekas c80a0ae
Merge branch '2.7' into 2.8
nicolas-grekas 2de494f
[WebProfilerBundle] Drop dead code
romainneutron 3d8959f
minor #22089 [2.8][WebProfilerBundle] Drop dead code (romainneutron)
nicolas-grekas b3f341f
Fixes a typo in the form collector styles
295a8e0
Merge branch '2.7' into 2.8
fabpot 3b1143c
Merge branch '2.7' into 2.8
fabpot 40a67c9
[WebProfilerBundle] Remove uneeded directive in the form collector st…
8aefa27
minor #22104 [WebProfilerBundle] Remove uneeded directive in the form…
fabpot e1ab801
Merge branch '2.7' into 2.8
fabpot 5f9d941
bug #22027 Revert "bug #21841 [Console] Do not squash input changes m…
fabpot 04caacb
[HttpFoundation] Fix missing handling of for/host/proto info from "Fo…
nicolas-grekas 8371dea
bug #21849 [HttpFoundation] Fix missing handling of for/host/proto in…
fabpot 89bb895
Merge branch '2.7' into 2.8
fabpot 3a7fa7e
Set Date header in Response constructor already
mpdude e3d90db
bug #22036 Set Date header in Response constructor already (mpdude)
fabpot d980e70
[WebProfilerBundle] Fix for CSS attribute at Profiler Translation Page
e-moe f354a47
bug #22123 [WebProfilerBundle] Fix for CSS attribute at Profiler Tran…
javiereguiluz f971f4f
Merge branch '2.7' into 2.8
fabpot d175340
Merge branch '2.7' into 2.8
fabpot a0e654d
Merge branch '2.7' into 2.8
nicolas-grekas fb4d8de
Avoid forcing to define the choices_as_values option when using choic…
stof 994e90c
minor #22230 [Form] Avoid forcing to define the choices_as_values opt…
fabpot 74ee588
support nullable array or collection
4rthem 992c677
[DI] Don't use auto-registered services to populate type-candidates
nicolas-grekas 9b60163
[DI] Autowiring and factories are incompatible with each others
nicolas-grekas d49005a
Merge branch '2.7' into 2.8
nicolas-grekas 80cea46
bug #22251 [PropertyInfo] Support nullable array or collection (4rthem)
dunglas ee10bf2
bug #22254 [DI] Don't use auto-registered services to populate type-c…
fabpot bad24d3
bug #22258 [DI] Autowiring and factories are incompatible with each o…
fabpot 6b862e8
Merge branch '2.7' into 2.8
fabpot 2fe1631
Allow Upper Case property names
insekticid 247e797
bug #22265 Allow Upper Case property names (insekticid)
fabpot 945fee1
Merge branch '2.7' into 2.8
fabpot 6e1cee6
[FrameworkBundle] Update console fixtures after #22217
ro0NL 200b45e
minor #22278 [FrameworkBundle] Update console fixtures after #22217 (…
nicolas-grekas f0c4b3f
updated CHANGELOG for 2.8.19
fabpot 19ccd43
updated VERSION for 2.8.19
fabpot da35163
Merge pull request #22284 from fabpot/release-2.8.19
fabpot d5ea533
bumped Symfony version to 2.8.20
fabpot f92ada8
Merge branch '2.7' into 2.8
fabpot 77927f4
[DI] Prevent AutowirePass from triggering irrelevant deprecations
chalasr 91b025a
bug #22282 [DI] Prevent AutowirePass from triggering irrelevant depre…
fabpot 8d0cfa4
Merge branch '2.7' into 2.8
nicolas-grekas c02de84
[DI] Fix second auto-registration
nicolas-grekas 0eb4d2a
bug #22311 [DI] Fix second auto-registration (nicolas-grekas)
fabpot 9f7a6bb
[HttpFoundation] Fix transient tests
nicolas-grekas f9d5ede
minor #22324 [HttpFoundation] Fix transient tests (nicolas-grekas)
fabpot 3672c01
[VarDumper] Relax tests to adapt for php 7.1rc4
nicolas-grekas 1272be6
minor #22332 [VarDumper] Relax tests to adapt for php 7.1rc4 (nicolas…
fabpot b89ed60
Merge branch '2.7' into 2.8
xabbuh 86b685f
fix risky tests
xabbuh 54fa2ff
minor #22379 fix risky tests (xabbuh)
fabpot 0bc5eea
Merge branch '2.7' into 2.8
nicolas-grekas d362bb1
Merge branch '2.7' into 2.8
fabpot 6edd08d
fail when detecting risky tests
fabpot 2be5821
[2.8] Prevent double registrations related to tag priorities
nicolas-grekas c839532
Merge branch '2.7' into 2.8
fabpot d564c6a
bug #22399 [2.8] Prevent double registrations related to tag prioriti…
fabpot b190ec2
[PropertyInfo] Prevent returning int values in some cases.
dunglas 7a8a72d
[PropertyInfo] Remove a useless call to count() in SerializerExtractor
dunglas f3eaa78
bug #22426 [PropertyInfo] Prevent returning int values in some cases …
fabpot f5609e8
minor #22427 [PropertyInfo] Remove a useless call to count() in Seria…
fabpot 9af7354
Merge branch '2.7' into 2.8
nicolas-grekas e9132b3
Fixed the flickering when loading complex profiler panels
javiereguiluz 76dd7b0
bug #22523 [WebProfilerBundle] Fixed the flickering when loading comp…
fabpot 3adff11
Merge branch '2.7' into 2.8
nicolas-grekas de1b20a
[Asset] Fix invalid assets.xml
nicolas-grekas 345b8c2
minor #22529 [Asset] Fix invalid assets.xml (nicolas-grekas)
fabpot 1bee0ad
Merge branch '2.7' into 2.8
nicolas-grekas d8c5869
[EventDispatcher] fix: unwrap listeners for correct info
dmaicher e9e4c79
bug #22541 [EventDispatcher] fix: unwrap listeners for correct info (…
fabpot b2b4faa
Allow Upper Case property names in ObjectNormalizer
insekticid 13f1707
Add iconv extension to suggested dependencies
julienfalque 04e48bd
minor #22557 [VarDumper] Add iconv dependency (julienfalque)
fabpot 07fc060
bug #22550 Allow Upper Case property names in ObjectNormalizer (insek…
fabpot 6000faf
Merge branch '2.7' into 2.8
fabpot f98aeb2
updated CHANGELOG for 2.8.20
fabpot db017eb
updated VERSION for 2.8.20
fabpot bbe1eae
Merge pull request #22599 from fabpot/release-2.8.20
fabpot 1f1b5d4
bumped Symfony version to 2.8.21
fabpot dfae2ab
Merge branch '2.7' into 2.8
nicolas-grekas 388ee46
[DependencyInjection] Don't store default deprecation template in eve…
fortis 0602fb5
minor #22628 [DependencyInjection] Don't store default deprecation te…
fabpot 57129de
Merge branch '2.7' into 2.8
fabpot ae3d88c
Merge branch '2.7' into 2.8
fabpot a23330b
fixed CS
fabpot 5e8412b
minor #22660 fixed CS (fabpot)
fabpot 433dfd4
Merge branch '2.7' into 2.8
fabpot 6ef78ec
Merge branch '2.7' into 2.8
nicolas-grekas b8c9597
Merge branch '2.7' into 2.8
fabpot 3d6d80d
Improved how profiler errors are dispalyed on small screens
javiereguiluz 80e2e1f
bug #22752 Improved how profiler errors are displayed on small screen…
fabpot f7b3252
Merge branch '2.7' into 2.8
nicolas-grekas fd7b084
Merge branch '2.7' into 2.8
nicolas-grekas 7a792eb
Merge branch '2.7' into 2.8
nicolas-grekas 321e41c
Merge branch '2.7' into 2.8
fabpot 2663293
Merge branch '2.7' into 2.8
fabpot 44cf367
Merge branch '2.7' into 2.8
fabpot 2c84ac2
Merge branch '2.7' into 2.8
fabpot 1140ae1
updated CHANGELOG for 2.8.21
fabpot ecf5780
updated VERSION for 2.8.21
fabpot 17002cb
Merge pull request #22946 from fabpot/release-2.8.21
fabpot af6b25b
bumped Symfony version to 2.8.22
fabpot 65297de
#22839 - changed debug toolbar dump section to relative and use full …
mkurzeja 47d5e6b
[PropertyInfo][DoctrineBridge] The bigint Doctrine's type must be con…
dunglas bd62b14
Merge branch '2.7' into 2.8
fabpot 7f4824c
add some \ on PHP_VERSION_ID for 2.8
vincentaubert 434c833
Merge branch '2.7' into 2.8
nicolas-grekas 3371db9
Fix optional cache warmers are always instantiated whereas they shoul…
romainneutron 99e0836
typo
nicolas-grekas 7a57644
bug #23014 [2.8]Fix optional cache warmers are always instantiated wh…
nicolas-grekas ec6b882
minor #23028 add some \ on PHP_VERSION_ID for 2.8 (vincentaubert)
nicolas-grekas 7632bed
bug #22988 [PropertyInfo][DoctrineBridge] The bigint Doctrine's type …
nicolas-grekas 1945bcf
typo
nicolas-grekas 0057459
Merge branch '2.7' into 2.8
nicolas-grekas 419556f
Merge branch '2.7' into 2.8
fabpot a9f289a
updated CHANGELOG for 2.8.22
fabpot 0d52ccb
updated VERSION for 2.8.22
fabpot 2404550
Merge pull request #23099 from fabpot/release-2.8.22
fabpot e8497bb
bumped Symfony version to 2.8.23
fabpot 895b123
Merge branch '2.7' into 2.8
fabpot 311cc8a
bug #22953 #22839 - changed debug toolbar dump section to relative an…
fabpot 5bc4ef0
Merge branch '2.7' into 2.8
fabpot e76ee7a
[Translation] Fix FileLoader::loadResource() php doc
ogizanagi d0065fe
minor #23219 [Translation] Fix FileLoader::loadResource() php doc (og…
fabpot 78f1fde
[WebProfilerBundle] Eliminate line wrap on count columnt (routing)
e-moe 46994a1
bug #23229 [WebProfilerBundle] Eliminate line wrap on count column (r…
javiereguiluz 1c091eb
[Console] Fix catching exception type in QuestionHelper
voronkovich be6af2e
Merge branch '2.7' into 2.8
fabpot b0bc9fe
bug #23240 [Console] Fix catching exception type in QuestionHelper (v…
fabpot b4aa027
Merge branch '2.7' into 2.8
xabbuh 0724ebc
Fix undefined variable $filesystem
nvasse 9a9c3d1
minor #23277 Fix undefined variable $filesystem (NVasse)
fabpot bddf9be
Merge branch '2.7' into 2.8
fabpot bf0063e
fixed tests
fabpot 28930c5
[WebProfilerBundle] Fix full sized dump hovering in toolbar
ogizanagi 2f8eeed
Merge branch '2.7' into 2.8
fabpot 26c5fc0
Merge branch '2.7' into 2.8
fabpot 2299864
updated CHANGELOG for 2.8.23
fabpot f9b4223
updated VERSION for 2.8.23
fabpot bca31e4
Merge pull request #23367 from fabpot/release-2.8.23
fabpot d011d57
bumped Symfony version to 2.8.24
fabpot ecaae23
Merge branch '2.7' into 2.8
fabpot d879eed
fixed bad merge
fabpot 442058d
Merge branch '2.7' into 2.8
fabpot 09797de
updated CHANGELOG for 2.8.24
fabpot bf1be0e
updated VERSION for 2.8.24
fabpot 0ab3693
Merge pull request #23401 from fabpot/release-2.8.24
fabpot 15df829
bumped Symfony version to 2.8.25
fabpot ca3ff88
Don't display the Symfony debug toolbar when printing the page
javiereguiluz 26ad2ad
bug #23460 Don't display the Symfony debug toolbar when printing the …
nicolas-grekas 6735b35
Merge branch '2.7' into 2.8
nicolas-grekas 0c6096f
Merge branch '2.7' into 2.8
nicolas-grekas 6ab8ca0
disable inlining deprecated services
alekitto a187a32
bug #23540 Disable inlining deprecated services (alekitto)
fabpot f49cc11
Merge branch '2.7' into 2.8
fabpot d3098b2
updated CHANGELOG for 2.8.25
fabpot 5836f0e
updated VERSION for 2.8.25
fabpot c2452af
Merge pull request #23553 from fabpot/release-2.8.25
fabpot 53b8579
bumped Symfony version to 2.8.26
fabpot f8f5c02
Merge branch '2.7' into 2.8
nicolas-grekas ce12665
Merge branch '2.7' into 2.8
fabpot 432d2de
Fixed typo in docblock
linaori 14a54a2
bug #23330 [WebProfilerBundle] Fix full sized dump hovering in toolba…
javiereguiluz
8000
Jul 21, 2017
6158ab3
Merge branch '2.7' into 2.8
nicolas-grekas 7816f3b
[DoctrineBridge][PropertyInfo] Added support for Doctrine Embeddables
vudaltsov 7428aba
bug #23023 [DoctrineBridge][PropertyInfo] Added support for Doctrine …
dunglas 17670e4
Merge branch '2.7' into 2.8
nicolas-grekas 57bf748
Merge branch '2.7' into 2.8
nicolas-grekas ee345ee
minor #23590 Fixed typo in docblock in AuthenticationExpiredException…
nicolas-grekas 4fe8889
Merge branch '2.7' into 2.8
nicolas-grekas 359e2d9
Merge branch '2.7' into 2.8
nicolas-grekas acd0af6
updated CHANGELOG for 2.8.26
fabpot d2e8f38
updated VERSION for 2.8.26
fabpot 3355310
Merge pull request #23735 from fabpot/release-2.8.26
fabpot 6f05beb
bumped Symfony version to 2.8.27
fabpot ce86449
Docblock improvement
vudaltsov 12dc1ce
minor #23732 [2.8][Security][Guard] Docblock improvement (vudaltsov)
chalasr 2807709
Merge branch '2.7' into 2.8
nicolas-grekas 684975d
Merge branch '2.7' into 2.8
nicolas-grekas 65fa8c2
Merge branch '2.7' into 2.8
nicolas-grekas 2309fd9
[2.8] Modify 2.8 upgrade doc - key option is deprecated.
cbaf5a1
minor #23826 [2.8] Modify 2.8 upgrade doc - key option is deprecated.…
fabpot 4879eb4
fixed CS
fabpot 18e5e70
Merge branch '2.7' into 2.8
fabpot daa0251
Merge branch '2.7' into 2.8
nicolas-grekas 6434a00
Merge branch '2.7' into 2.8
nicolas-grekas fbd4a20
Tests for EntityType field with multiple=true
stoccc ead3685
Update EntityTypeTest.php
stoccc 0940e3e
Update MergeCollectionListener.php
stoccc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update EntityTypeTest.php
- Loading branch information
commit ead368583a9c67c98894bab5502574fd9865a8d4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial & expected data should be an
ArrayCollection()
for both cases, see other testssymfony/src/Symfony/Bridge/Doctrine/Tests/Form/Type/EntityTypeTest.php
Lines 416 to 422 in 1732cc8
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yceruto I think there is also a documentation issue here because it's said that returned value is an
array
http://symfony.com/doc/current/reference/forms/types/entity.html#multipleBtw I'll change tests tomorrow(Edit: I didn't see #23927 (comment), so I won't change tests if I understood)