8000 [HttpKernel] Clean test directory on tear down by nicolas-grekas · Pull Request #23893 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Clean test directory on tear down #23893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2017
Merged

[HttpKernel] Clean test directory on tear down #23893

merged 1 commit into from
Aug 15, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

I've been bitten by this leftover too often.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Aug 15, 2017
chalasr
chalasr approved these changes Aug 15, 2017
View reviewed changes
Copy link
Member
@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

chalasr
chalasr reviewed Aug 15, 2017
View reviewed changes
src/Symfony/Component/HttpKernel/Tests/KernelTest.php Outdated
@@ -25,6 +26,11 @@

class KernelTest extends TestCase
{
public static function tearDownAfterClass()
{
(new Filesystem())->remove(__DIR__.'/Fixtures/cache');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, syntax error on 5.3...

@nicolas-grekas nicolas-grekas merged commit 0a3dc11 into symfony:2.7 Aug 15, 2017
nicolas-grekas added a commit that referenced this pull request Aug 15, 2017
@nicolas-grekas
minor #23893 [HttpKernel] Clean test directory on tear down (nicolas-…
0b613db 
…grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[HttpKernel] Clean test directory on tear down

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I've been bitten by this leftover too often.

Commits
-------

0a3dc11 [HttpKernel] Clean test directory on tear down
@nicolas-grekas nicolas-grekas deleted the kernel-clean-test branch August 15, 2017 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
HttpKernel Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @chalasr @carsonbot
0