8000 [DI] Validate env vars in config by ro0NL · Pull Request #23888 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Validate env vars in config #23888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[DI] Validate env vars in config #23888

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
68ee20e
[DI] Validate env vars in config
ro0NL Mar 3, 2018
d33b1c8
optimized
ro0NL Mar 3, 2018
e7b9656
feedback
ro0NL Mar 21, 2018
1e59cf7
added changelog entry
ro0NL Mar 21, 2018
a90d34b
phpdocs
ro0NL Mar 22, 2018
e5f02cd
mark internal
ro0NL Mar 22, 2018
c76adcd
Update BaseNode.php
ro0NL Mar 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
phpdocs
  • Loading branch information
@ro0NL
ro0NL committed Mar 22, 2018
commit a90d34b7f01c4393529fa7bba228fe9d82300e43
20 changes: 11 additions & 9 deletions src/Symfony/Component/Config/Definition/BaseNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ public function __construct(?string $name, NodeInterface $parent = null, string
}

/**
* Register possible (dummy) values for a dynamic placeholder value. Matching configuration values will be processed
* with a provided value, one by one. After a provided value is successfully processed the configuration value is
* returned as is, thus preserving the placeholder.
* Register possible (dummy) values for a dynamic placeholder value.
*
* Matching configuration values will be processed with a provided value, one by one. After a provided value is
* successfully processed the configuration value is returned as is, thus preserving the placeholder.
*/
public static function setPlaceholder(string $placeholder, array $values): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addPlaceholder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general i prefer a[k] = v to be a setter, and a[] = v to be adder.

We also used set() in di fluent config, same topic :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also setAttribute here :)

{
Expand All @@ -71,17 +72,18 @@ public static function setPlaceholder(string $placeholder, array $values): void
}

/**
* Set a common prefix for dynamic placeholder values. Matching configuration values will be skipped from being
* processed and are returned as is, thus preserving the placeholder. An exact match provided by {@see setPlaceholder()}
* might take precedence.
* Sets a common prefix for dynamic placeholder values.
*
* Matching configuration values will be skipped from being processed and are returned as is, thus preserving the
* placeholder. An exact match provided by {@see setPlaceholder()} might take precedence.
*/
public static function setPlaceholderUniquePrefix(string $prefix): void
{
self::$placeholderUniquePrefix = $prefix;
}

/**
* Reset all current placeholders available.
* Resets all current placeholders available.
*/
public static function resetPlaceholders(): void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one also needs to be internal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops :) updated.

{
Expand Down Expand Up @@ -461,15 +463,15 @@ abstract protected function mergeValues($leftSide, $rightSide);
abstract protected function finalizeValue($value);

/**
* Test if placeholder values are allowed for this node.
* Tests if placeholder values are allowed for this node.
*/
protected function allowPlaceholders(): bool
{
return true;
}

/**
* Get allowed dynamic types for this node.
* Gets allowed dynamic types for this node.
*/
protected function getValidPlaceholderTypes(): array
{
Expand Down
0