8000 [HttpKernel] Remove old container files by nicolas-grekas · Pull Request #23873 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpKernel] Remove old container files #23873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2017
Merged

[HttpKernel] Remove old container files #23873

merged 1 commit into from
Aug 16, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23872
License MIT
Doc PR -

ping @mvrhov

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 12, 2017
@nicolas-grekas
Copy link
Member Author

Status: needs work

If the new container is the same as the old, we shouldn't remove the files.

@nicolas-grekas nicolas-grekas force-pushed the kernel-clear-container branch from ec67f4e to 8701702 Compare August 12, 2017 16:49
@nicolas-grekas
Copy link
Member Author

Fixed
Status: needs review

@sstok
Copy link
Contributor
sstok commented Aug 13, 2017

No tests? 🙀

@nicolas-grekas nicolas-grekas force-pushed the kernel-clear-container branch 2 times, most recently from 9eeb85d to f9dcbb9 Compare August 15, 2017 09:48
@nicolas-grekas nicolas-grekas force-pushed the kernel-clear-container branch from f9dcbb9 to 2e4e6ad Compare August 15, 2017 13:42
@nicolas-grekas
Copy link
Member Author

@sstok now with tests :)

@nicolas-grekas nicolas-grekas merged commit 2e4e6ad into symfony:3.4 Aug 16, 2017
nicolas-grekas added a commit that referenced this pull request Aug 16, 2017
@nicolas-grekas
bug #23873 [HttpKernel] Remove old container files (nicolas-grekas)
ff62871 
This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] Remove old container files

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23872
| License       | MIT
| Doc PR        | -

ping @mvrhov

Commits
-------

2e4e6ad [HttpKernel] Remove old container files
@nicolas-grekas nicolas-grekas deleted the kernel-clear-container branch August 16, 2017 16:06
stof
stof reviewed Aug 16, 2017
View reviewed changes
src/Symfony/Component/HttpKernel/Kernel.php
}

if ($oldContainer && get_class($this->container) !== $oldContainer->name) {
(new Filesystem())->remove(dirname($oldContainer->getFileName()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this remove the whole cache dir ? This is not good, as it is not all about the DIC cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@sstok sstok sstok approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @sstok @stof @ogizanagi @chalasr @carsonbot
0