8000 [Profiler] Fix request_collector check in main layout by ogizanagi · Pull Request #23806 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Profiler] Fix request_collector check in main layout #23806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2017
Merged

[Profiler] Fix request_collector check in main layout #23806

merged 1 commit into from
Aug 6, 2017

Conversation

ogizanagi
Copy link
Contributor
Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

I minor issue I hit when debugging and disabling some collectors some time ago.

@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit c35cdba into symfony:3.3 Aug 6, 2017
nicolas-grekas added a commit that referenced this pull request Aug 6, 2017
…zanagi)

This PR was merged into the 3.3 branch.

Discussion
----------

[Profiler] Fix request_collector check in main layout

| Q             | A
| ------------- | ---
| Branch?       | 3.3 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

I minor issue I hit when debugging and disabling some collectors some time ago.

Commits
-------

c35cdba [Profiler] Fix request_collector check in main layout
@ogizanagi ogizanagi deleted the fix/3.3/profiler/rm_request_collector_defined branch August 6, 2017 13:41
@fabpot fabpot mentioned this pull request Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0