-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PropertyAccess] add naming strategy #23789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
DavidBadura
wants to merge
1
commit into
symfony:master
from
DavidBadura:property-access-naming-strategy
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
src/Symfony/Component/PropertyAccess/NamingStrategy/CamelCaseStrategy.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\PropertyAccess\NamingStrategy; | ||
|
||
use Symfony\Component\Inflector\Inflector; | ||
|
||
/** | ||
* @author David Badura <d.a.badura@gmail.com> | ||
*/ | ||
class CamelCaseStrategy implements NamingStrategyInterface | ||
{ | ||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getGetters(string $class, string $property): array | ||
{ | ||
$camelProp = self::camelize($property); | ||
|
||
return array( | ||
'get'.$camelProp, | ||
lcfirst($camelProp), // jQuery style, e.g. read: last(), write: last($item) | ||
'is'.$camelProp, | ||
'has'.$camelProp, | ||
); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getSetters(string $class, string $property): array | ||
{ | ||
$camelized = self::camelize($property); | ||
|
||
return array( | ||
'set'.$camelized, | ||
lcfirst($camelized), // jQuery style, e.g. read: last(), write: last($item) | ||
); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function getAddersAndRemovers(string $class, string $property): array | ||
{ | ||
$singulars = (array) Inflector::singularize(self::camelize($property)); | ||
|
||
return array_map(function ($singular) { | ||
return array('add'.$singular, 'remove'.$singular); | ||
}, $singulars); | ||
} | ||
|
||
private static function camelize(string $string): string | ||
{ | ||
return str_replace(' ', '', ucwords(str_replace('_', ' ', $string))); | ||
} | ||
} |
48 changes: 48 additions & 0 deletions
48
src/Symfony/Component/PropertyAccess/NamingStrategy/NamingStrategyInterface.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <fabien@symfony.com> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Component\PropertyAccess\NamingStrategy; | ||
|
||
/** | ||
* @author David Badura <d.a.badura@gmail.com> | ||
*/ | ||
interface NamingStrategyInterface | ||
{ | ||
/** | ||
* Returns all possible getters. | ||
* | ||
* @param string $class | ||
* @param string $property | ||
* | ||
* @return array | ||
*/ | ||
public function getGetters(string $class, string $property): array; | ||
|
||
/** | ||
* Returns all possible setters. | ||
* | ||
* @param string $class | ||
* @param string $property | ||
* | ||
* @return array | ||
*/ | ||
public function getSetters(string $class, string $property): array; | ||
|
||
/** | ||
* Returns all possible adders and removers. | ||
* | ||
* @param string $class | ||
* @param string $property | ||
* | ||
* @return array | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What structure should be used for return? Maybe better split for |
||
*/ | ||
public function getAddersAndRemovers(string $class, string $property): array; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PHPDocs has no sense: they just duplicates typehints. But we can better describe return:
@return string[]
.