8000 [FrameworkBundle] Warmup annotations for bundle-less controllers and entities by nicolas-grekas · Pull Request #23776 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Warmup annotations for bundle-less controllers and entities #23776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2017
Merged

[FrameworkBundle] Warmup annotations for bundle-less controllers and entities #23776

merged 1 commit into from
Aug 5, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Aug 3, 2017
@mvrhov
Copy link
mvrhov commented Aug 3, 2017 •
edited
Loading

Doesn't this break the compatibility with apps that use bundles?
edit: Ah was too quick. Now it catches everything.

@nicolas-grekas
Copy link
Member Author

I don't think so, the pattern matches both styles, isn't it?

@nicolas-grekas nicolas-grekas merged commit feb5e62 into symfony:3.3 Aug 5, 2017
nicolas-grekas added a commit that referenced this pull request Aug 5, 2017
@nicolas-grekas
bug #23776 [FrameworkBundle] Warmup annotations for bundle-less contr…
c099f58 
…ollers and entities (nicolas-grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Warmup annotations for bundle-less controllers and entities

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

feb5e62 [FrameworkBundle] Warmup annotations for bundle-less controllers and entities
@nicolas-grekas nicolas-grekas deleted the bundle-less branch August 5, 2017 14:39
@fabpot fabpot mentioned this pull request Aug 28, 2017
Merged
@ogizanagi ogizanagi mentioned this pull request Dec 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @mvrhov @javiereguiluz @chalasr @carsonbot
0