8000 [Form] Add notice to upgrade to PHP v7.0.8+ by nicolas-grekas · Pull Request #23705 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Add notice to upgrade to PHP v7.0.8+ #23705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2017
Merged

[Form] Add notice to upgrade to PHP v7.0.8+ #23705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Form] Add notice to upgrade to PHP v7.0.8+
  • Loading branch information
@nicolas-grekas
nicolas-grekas committed Jul 28, 2017
commit 0347e5a5d3cf2831f3d9a986bdca793058bb7849
3 changes: 3 additions & 0 deletions src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ public function __construct(FormDataExtractorInterface $dataExtractor)
*/
public function collect(Request $request, Response $response, \Exception $exception = null)
{
if (70000 <= \PHP_VERSION_ID && \PHP_VERSION_ID < 70800) {
@trigger_error('A bug in PHP v7.0.0 to v7.0.7 is breaking the Form panel, please upgrade to v7.0.8 or more.', E_USER_DEPRECATED);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/more/higher/ ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that's better. Done in a6f44d2. Thanks for the suggestion.

}
}

/**
Expand Down
0