8000 [ProxyManager] Cleanup fixtures by nicolas-grekas · Pull Request #23689 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[ProxyManager] Cleanup fixtures #23689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2017
Merged

[ProxyManager] Cleanup fixtures #23689

merged 1 commit into from
Jul 28, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Just noticed that these fixture files are not maintainable. And we don't need them at all in fact, let's drop them.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Jul 27, 2017
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 27, 2017
Closed
@fabpot
Copy link
Member
fabpot commented Jul 28, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 31843d6 into symfony:2.7 Jul 28, 2017
fabpot added a commit that referenced this pull request Jul 28, 2017
@fabpot
minor #23689 [ProxyManager] Cleanup fixtures (nicolas-grekas)
3f31266 
This PR was merged into the 2.7 branch.

Discussion
----------

[ProxyManager] Cleanup fixtures

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Just noticed that these fixture files are not maintainable. And we don't need them at all in fact, let's drop them.

Commits
-------

31843d6 [ProxyManager] Cleanup fixtures
@nicolas-grekas nicolas-grekas deleted the proxy-clean branch July 28, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @fabpot @stof @chalasr @carsonbot
0