[WebProfilerBundle] Re add missing link to the controller #23676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes (because it was on 3.2 but not in 3.3) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
It's nice to have this feature back ... but I'm afraid it looks very ugly. What if we use a style similar to the sub-requests?
We could display the controller only in the Request tab, like this:
|
|
Oh you find it ugly :( My bad I was proud of my work :D Actually, my first attempt was what you proposed. And I found it ugly; jajaja. Note: I moved the link on top of the tab name because the controller is related to the request / response et / etc. and not only the request. |
82556e7 to
25aed5c
Compare
|
What if we display the controller like this:
And reduce the font-size of sub-requests controllers to 18px to display a better hierarchy:
|
25aed5c to
1d10857
Compare
|
WDYT? As you can see, I did not had to change the CSS, And I'm quite happy to not add special rules for this. |
nicolas-grekas
approved these changes
Aug 22, 2017
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Aug 22, 2017
…(lyrixx) This PR was merged into the 3.3 branch. Discussion ---------- [WebProfilerBundle] Re add missing link to the controller | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes (because it was on 3.2 but not in 3.3) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ---  Commits ------- 1d10857 [WebProfilerBundle] Re add missing link to the controller
Merged
javiereguiluz
added a commit
that referenced
this pull request
Sep 27, 2017
…tsykun) This PR was merged into the 3.3 branch. Discussion ---------- [WebProfilerBundle] Added missing link to profile token | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes, it was on 3.3.6 (before merge #23676) | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - On v3.3.6 I can open profiles for sub-request on this link  But after 3.3.7 it was replaced by links to the controller. In this pull request was added missing link to the profile  Commits ------- c388b25 [WebProfilerBundle] Added missing link to profile token
symfony-splitter
pushed a commit
to symfony/web-profiler-bundle
that referenced
this pull request
Sep 27, 2017
…tsykun) This PR was merged into the 3.3 branch. Discussion ---------- [WebProfilerBundle] Added missing link to profile token | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes, it was on 3.3.6 (before merge symfony/symfony#23676) | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - On v3.3.6 I can open profiles for sub-request on this link  But after 3.3.7 it was replaced by links to the controller. In this pull request was added missing link to the profile  Commits ------- c388b25cbb [WebProfilerBundle] Added missing link to profile token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.