8000 [DI] Change "this" to "that" in `findAndSortTaggedServices` doc to reduce confusion by simshaun · Pull Request #23578 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[DI] Change "this" to "that" in findAndSortTaggedServices doc to reduce confusion #23578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2,047 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
2047 commits
Select commit Hold shift + click to select a range
976b93a
[Yaml] deprecate the !str tag
xabbuh Jun 24, 2017
b1e8ebc
[Yaml] Support tagged scalars
GuilhemN May 18, 2017
abe3440
[Translation] Uncomment YamlFileDumper constructor arg typehint
ogizanagi Jun 25, 2017
a617d4b
minor #23289 [Translator] Uncomment YamlFileDumper constructor arg ty…
fabpot Jun 25, 2017
e4ec8e9
[Process] remove deprecated features
xabbuh Jun 26, 2017
8483564
feature #22836 [Process] remove deprecated features (xabbuh)
fabpot Jun 28, 2017
b31ebae
Allow * to bind all interfaces (as INADDR_ANY)
Jun 28, 2017
8014b38
[Security] Fix Firewall ExceptionListener priority
chalasr Jun 24, 2017
f527790
[Security] remove support for defining voters that don't implement th…
Jun 28, 2017
6cd188b
[FrameworkBundle] Display a proper warning on cache:clear without the…
ogizanagi Jun 29, 2017
c6d19b1
[Yaml][Twig][Lint] Added line numbers to JSON output.
WybrenKoelmans Jun 29, 2017
0932183
feature #23294 [Yaml][Lint] Add line numbers to JSON output. (WybrenK…
fabpot Jun 29, 2017
1c106da
feature #23324 [Security] remove support for defining voters that don…
fabpot Jun 29, 2017
1baac5a
feature #23294 [Yaml][Lint] Add line numbers to JSON output. (WybrenK…
fabpot Jun 29, 2017
a2ae6bf
[Yaml] fix the displayed line number
xabbuh Jun 30, 2017
7787343
feature #23332 [Yaml] fix the displayed line number (fabpot, xabbuh)
fabpot Jun 30, 2017
d7992dc
Merge branch '3.4'
fabpot Jun 30, 2017
8b6cb57
bug #23328 [FrameworkBundle] Display a proper warning on cache:clear …
fabpot Jun 30, 2017
1beee41
remove no longer valid docblock description
xabbuh Jun 30, 2017
66a4fd7
parse escaped quotes in unquoted env var values
xabbuh Jun 30, 2017
baafc7b
[Dotenv] clean up before running assertions
xabbuh Jul 1, 2017
10120cf
minor #23347 [Dotenv] clean up before running assertions (xabbuh)
fabpot Jul 3, 2017
39075cf
minor #23336 [HttpFoundation] remove no longer valid docblock descrip…
fabpot Jul 3, 2017
98be08b
feature #23272 [FrameworkBundle] disable unusable fragment renderers …
fabpot Jul 3, 2017
1b0e920
bug #23291 [Security] Fix Firewall ExceptionListener priority (chalasr)
fabpot Jul 3, 2017
0531316
minor #23281 Fix typo in docblock (shude)
fabpot Jul 3, 2017
1880bcf
fixed CS
fabpot Jul 3, 2017
9bcb852
feature #23320 [WebServer] Allow * to bind all interfaces (as INADDR_…
fabpot Jul 3, 2017
bfd4173
bug #23342 [Dotenv] parse escaped quotes in unquoted env var values (…
fabpot Jul 3, 2017
b23ddfe
feature #23285 [Stopwatch] Add a reset method (jmgq)
fabpot Jul 3, 2017
aaaf64d
[Dotenv] parse concatenated variable values
xabbuh Jun 30, 2017
471b84c
Remove HHVM support (second edition)
Nek- Jun 17, 2017
b12f215
minor #23216 Remove HHVM support (second edition) (Nek-)
nicolas-grekas Jul 3, 2017
1dbdf1c
Add DateCaster
maidmaid Apr 14, 2017
9260a7b
Merge branch '3.2' into 3.3
fabpot Jul 3, 2017
886df99
Merge branch '3.3' into 3.4
fabpot Jul 3, 2017
3041b4c
Merge branch '3.4'
fabpot Jul 3, 2017
f3867e6
add changelog entry for Stopwatch::reset()
xabbuh Jul 3, 2017
d261894
Change wording from object to subject
Jun 15, 2017
f9173ea
minor #23201 Change wording from object to subject (greg0ire)
fabpot Jul 3, 2017
6080220
minor #23353 [Stopwatch] add changelog entry for Stopwatch::reset() (…
fabpot Jul 3, 2017
d6271d7
feature #22431 [VarDumper] Add date caster (maidmaid)
nicolas-grekas Jul 3, 2017
3169e12
bug #23351 [Dotenv] parse concatenated variable values (xabbuh)
fabpot Jul 3, 2017
ccfc4da
feature #23039 [Validator] Support for parsing PHP constants in yaml …
fabpot Jul 3, 2017
73d3d40
feature #23288 [Yaml] deprecate the !str tag (xabbuh)
fabpot Jul 3, 2017
5a3abf5
feature #22588 [VarDumper] Add filter in VarDumperTestTrait (maidmaid)
nicolas-grekas Jul 3, 2017
3ddb6e6
[Console] Fix descriptor tests
chalasr Jul 3, 2017
c25bc24
minor #23360 [Console] Fix descriptor tests (chalasr)
fabpot Jul 3, 2017
d43355c
Merge branch '3.3' into 3.4
fabpot Jul 3, 2017
1437caf
Merge branch '3.4'
fabpot Jul 3, 2017
d7914a6
[Security] Lazy load user providers
chalasr Jul 3, 2017
a40b29b
Merge branch '3.2' into 3.3
fabpot Jul 3, 2017
ddc4b20
Merge branch '3.3' into 3.4
fabpot Jul 3, 2017
b092d1b
Merge branch '3.4'
fabpot Jul 3, 2017
1d07a28
call setContainer() for autowired controllers
xabbuh Jun 20, 2017
966662d
bug #23239 [FrameworkBundle] call setContainer() for autowired contro…
nicolas-grekas Jul 3, 2017
e0913a2
add option to define the access decision manager
xabbuh Jan 15, 2016
41fecee
Remove hhvm compat
maidmaid Jul 3, 2017
e2b6efa
Remove bc layer
maidmaid Jul 3, 2017
c73dae3
[Serializer] Remove DateTimeNormalizer PHP < 7 bc layer
ogizanagi Jul 3, 2017
e5bb2bc
[DI][DoctrineBridge] Remove unused underscoreMap properties
dunglas Jun 25, 2017
511ebed
minor #23362 [VarDumper] Remove HHVM compat in date caster (maidmaid)
fabpot Jul 4, 2017
26ee3cc
minor #23363 [VarDumper] Remove bc layer in trait (maidmaid)
fabpot Jul 4, 2017
10da788
minor #23364 [Serializer] Remove DateTimeNormalizer PHP < 7 bc layer …
fabpot Jul 4, 2017
06e21f7
minor #23300 [DI] Remove an unused property (dunglas)
fabpot Jul 4, 2017
8b1f412
Merge branch '3.2' into 3.3
fabpot Jul 4, 2017
fcb6171
updated CHANGELOG for 3.3.3
fabpot Jul 4, 2017
5d8d746
updated VERSION for 3.3.3
fabpot Jul 4, 2017
098bb16
Merge pull request #23369 from fabpot/release-3.3.3
fabpot Jul 4, 2017
5de56eb
bumped Symfony version to 3.3.4
fabpot Jul 4, 2017
a32cae5
[FrameworkBundle] Wire inner translator
ogizanagi Jul 3, 2017
c75e486
[FrameworkBundle] 3.3: Don't get() private services from debug:router
ogizanagi Jul 4, 2017
6033503
Remove enhancement Windows compatibility
maidmaid Jul 4, 2017
a1c77e7
bug #23370 [FrameworkBundle] Wire inner translator (ogizanagi)
fabpot Jul 4, 2017
9737bcc
[DoctrineBridge] Use normalizedIds for resetting entity manager services
chalasr Jul 4, 2017
7f52292
feature #23376 [Process] Remove enhanced Windows compatibility (maidm…
fabpot Jul 4, 2017
452c56a
bug #23371 [FrameworkBundle] 3.3: Don't get() private services from d…
fabpot Jul 4, 2017
9011aa1
Remove !str support
maidmaid Jul 4, 2017
e726337
minor #23387 [Yaml] Remove !str tag support (maidmaid)
fabpot Jul 4, 2017
61e262f
Remove of boolean value for the checkDNS option
maidmaid Jul 4, 2017
19c6a6f
Add some meta infos
maidmaid Jul 4, 2017
ac107ba
[Validator] improve the changelog
xabbuh Jul 4, 2017
56f72d7
Merge branch '3.2' into 3.3
nicolas-grekas Jul 5, 2017
6e33739
feature #23391 [Validator] Remove support of boolean value for the ch…
fabpot Jul 5, 2017
8fb89be
minor #23392 Add some missing changelog/upgrade infos (maidmaid)
fabpot Jul 5, 2017
5768424
Merge branch '3.2' into 3.3
fabpot Jul 5, 2017
e9dc82a
Merge branch '3.3'
fabpot Jul 5, 2017
bef2142
bug #23385 [DoctrineBridge] Fix resetting entity managers with case s…
fabpot Jul 5, 2017
5d35184
Remove the RenameEntryInterface interface
maidmaid Jul 5, 2017
959ac2a
[Serializer] AbstractObjectNormalizer: Allow to disable type enforcement
ogizanagi Jul 5, 2017
70bd2bc
[VarDumper] Reduce size of serialized Data objects
nicolas-grekas Jul 5, 2017
3e84f7d
bug #23413 [VarDumper] Reduce size of serialized Data objects (nicola…
fabpot Jul 5, 2017
a7c9d1a
updated CHANGELOG for 3.3.4
fabpot Jul 5, 2017
10000
e81d5d1
updated VERSION for 3.3.4
fabpot Jul 5, 2017
82f7cba
Merge pull request #23414 from fabpot/release-3.3.4
fabpot Jul 5, 2017
94b6ec3
bumped Symfony version to 3.3.5
fabpot Jul 5, 2017
a15829d
[Component][Serializer][Normalizer] : Deal it with Has Method for the…
jsamouh Jun 30, 2017
f7bca74
feature #23337 [Component][Serializer][Normalizer] : Deal it with Has…
fabpot Jul 6, 2017
7e93cca
Merge branch '3.2' into 3.3
fabpot Jul 6, 2017
6065ba6
Merge branch '3.3'
fabpot Jul 6, 2017
6aa6644
added missing type hints
fabpot Jul 6, 2017
b9d93c8
feature #23402 [Ldap] Remove the RenameEntryInterface interface (maid…
fabpot Jul 6, 2017
3981f9b
feature #22620 [FrameworkBundle][HttpKernel] Move httpkernel pass (le…
fabpot Jul 6, 2017
bfaf8a0
feature #22619 [FrameworkBundle][Translation] Move translation compil…
fabpot Jul 6, 2017
bbd0c7f
Fix deprecated message
maidmaid Jul 6, 2017
680da44
[BrowserKit] Emulate back/forward browser navigation
e-moe Apr 7, 2017
0d06bbc
feature #22341 [BrowserKit] Emulate back/forward browser navigation (…
fabpot Jul 6, 2017
43212b9
[DX] [TwigBundle] Enhance the new exception page design
sustmi Apr 14, 2017
626e987
bug #22439 [DX] [TwigBundle] Enhance the new exception page design (s…
fabpot Jul 6, 2017
48bb195
minor #23422 [Ldap] Fix deprecated message (maidmaid)
fabpot Jul 6, 2017
fd01d7a
fixed CHANGELOG
fabpot Jul 6, 2017
9ab5263
add minimum and maximum amount of pixels to Image validator
Apr 5, 2017
73187d0
Preserve HttpOnly value when deserializing a header
Toflar Jul 6, 2017
0db8d7f
Add support for microseconds in Stopwatch
javiereguiluz Jun 19, 2017
82036a3
feature #23223 Add support for microseconds in Stopwatch (javiereguiluz)
fabpot Jul 6, 2017
f8be69d
Remove TemplateManager::getTemplates()
maidmaid Jul 6, 2017
71c6f99
bug #23426 Fixed HttpOnly flag when using Cookie::fromString() (Toflar)
fabpot Jul 6, 2017
7796331
feature #23431 [Validator] Add min/max amount of pixels to Image cons…
fabpot Jul 6, 2017
7685880
fixed CS
fabpot Jul 6, 2017
984c1c7
minor #23427 [WebProfilerBundle] Remove deprecated TemplateManager::g…
fabpot Jul 6, 2017
a20426d
fixed CS
fabpot Jul 6, 2017
5a37f84
[HttpFoundation] Find the original request protocol version
thewilkybarkid Jan 31, 2017
4f187ce
feature #21469 [HttpFoundation] Find the original request protocol ve…
fabpot Jul 6, 2017
26641bd
fixed tests
fabpot Jul 6, 2017
04b8b80
Deprecate support for stacked errors
mbabker May 21, 2017
7ac2570
feature #22832 [Debug] Deprecate support for stacked errors (mbabker)
nicolas-grekas Jul 6, 2017
47ee1d5
Merge branch '3.3' into 3.4
nicolas-grekas Jul 6, 2017
c5cbc83
feature #22762 [Yaml] Support tagged scalars (GuilhemN)
fabpot Jul 6, 2017
a416007
Merge branch '3.4'
nicolas-grekas Jul 6, 2017
1c1a86f
Merge remote-tracking branch 'origin/master'
nicolas-grekas Jul 6, 2017
76dc317
Removed ContextErrorException
mbabker May 20, 2017
1dfcdc7
[DotEnv] Fix variable substitution
brieucthomas Jul 6, 2017
c3ec5c5
bug #23434 [DotEnv] Fix variable substitution (brieucthomas)
fabpot Jul 6, 2017
7974cd7
feature #22804 [Debug] Removed ContextErrorException (mbabker)
nicolas-grekas Jul 6, 2017
0bcc5af
Minor cleanups
nicolas-grekas Jul 6, 2017
d203ee3
Merge branch '3.4'
nicolas-grekas Jul 6, 2017
dc3f7a9
[Routing] Add matched and default parameters to redirect responses
artursvonda Jul 11, 2014
07c5aa6
[Validator] Allow to use a property path to get value to compare in c…
ogizanagi Jul 4, 2017
632e934
[DI] Allow imports in string format for YAML
ro0NL Mar 27, 2017
9b8d96b
[Validator] sync upgrade file with latest code changes
xabbuh Jul 9, 2017
754d3a7
[HttpKernel][VarDumper] Truncate profiler data & optim perf
nicolas-grekas Jul 10, 2017
0b349ae
check _controller attribute is a string before parsing it
alekitto Jul 8, 2017
85766c9
Add exculde verbosity test
maidmaid Jul 10, 2017
4c1fdd4
[Routing] also add matched params for redirect due to trailing slash
Tobion Jun 12, 2016
4c483ba
bug #23457 [FrameworkBundle] check _controller attribute is a string …
nicolas-grekas Jul 11, 2017
38905d3
feature #23440 [Routing] Add matched and default parameters to redire…
nicolas-grekas Jul 11, 2017
22b67a4
Merge branch '3.2' into 3.3
nicolas-grekas Jul 11, 2017
77b8ea7
Merge branch '3.3' into 3.4
nicolas-grekas Jul 11, 2017
2291484
Merge branch '3.4'
nicolas-grekas Jul 11, 2017
bd30a27
minor #23470 [VarDumper] Test ExceptionCaster excluding verbosity (ma…
nicolas-grekas Jul 11, 2017
2b3afd2
bug #23465 [HttpKernel][VarDumper] Truncate profiler data & optim per…
nicolas-grekas Jul 11, 2017
e535089
Add exculde verbosity test
maidmaid Jul 10, 2017
8826da1
[Process] Fix parsing args on Windows
nicolas-grekas Jul 11, 2017
050d686
feature #23295 [Security] Lazy load user providers (chalasr)
nicolas-grekas Jul 11, 2017
6db73d3
Merge branch '3.4'
nicolas-grekas Jul 11, 2017
f9d73b9
feature #22176 [DI] Allow imports in string format for YAML (ro0NL)
fabpot Jul 11, 2017
63e26fc
[DI] Remove deprecated case insensitive service ids
ro0NL May 20, 2017
a55cbf8
feature #22811 [DI] Remove deprecated case insensitive service ids (r…
nicolas-grekas Jul 11, 2017
ba8763b
[TwigBundle] Added a RuntimeExtensionInterface to take advantage of a…
lyrixx Jun 2, 2017
66ead2e
minor #23476 [VarDumper] Test ReflectionCaster excluding verbosity (m…
nicolas-grekas Jul 11, 2017
954e9f1
feature #23037 [TwigBundle] Added a RuntimeExtensionInterface to take…
nicolas-grekas Jul 12, 2017
e659ec1
bug #23477 [Process] Fix parsing args on Windows (nicolas-grekas)
nicolas-grekas Jul 12, 2017
7f97519
Add support for command lazy-loading
chalasr Jul 12, 2017
4bd7b92
[DI] Remove remaining deprecated features
nicolas-grekas Jul 12, 2017
afaf299
feature #19034 [Security] make it possible to configure a custom acce…
nicolas-grekas Jul 12, 2017
c8f2c96
feature #22734 [Console] Add support for command lazy-loading (chalasr)
nicolas-grekas Jul 12, 2017
3b2f9fb
feature #22689 [DoctrineBridge] Add support for doctrin/dbal v2.6 typ…
nicolas-grekas Jul 12, 2017
ab8ac13
feature #22576 [Validator] Allow to use a property path to get value …
nicolas-grekas Jul 12, 2017
1aa7d68
Remove enhance sigchild compatibility
maidmaid Jul 4, 2017
6b5d35f
Merge branch '3.2' into 3.3
nicolas-grekas Jul 12, 2017
4324804
Merge branch '3.3' into 3.4
nicolas-grekas Jul 12, 2017
3763515
Add TokenProcessor
maidmaid Dec 25, 2016
21b7fd4
feature #21086 [MonologBridge] Add TokenProcessor (maidmaid)
nicolas-grekas Jul 12, 2017
1041f82
feature #23380 [Process] Remove enhanced sigchild compatibility (maid…
nicolas-grekas Jul 12, 2017
bdaa7b1
Merge branch '3.4'
nicolas-grekas Jul 12, 2017
5f91f74
feature #23404 [Serializer] AbstractObjectNormalizer: Allow to disabl…
nicolas-grekas Jul 12, 2017 10000
d09aeaf
Merge branch '3.2' into 3.3
nicolas-grekas Jul 12, 2017
8e6accc
fix merge
nicolas-grekas Jul 12, 2017
c937180
Merge branch '3.3' into 3.4
nicolas-grekas Jul 12, 2017
9290042
Merge branch '3.4'
nicolas-grekas Jul 12, 2017
d1cfec1
Merge branch '3.2' into 3.3
nicolas-grekas Jul 12, 2017
2ed4cfb
Merge branch '3.3' into 3.4
nicolas-grekas Jul 12, 2017
c4b6066
[DI] Check privates before resolving alias in Container::initialized
ro0NL Jul 12, 2017
8289ca6
non-conflicting anonymous service ids across files
xabbuh Jul 12, 2017
5161ec6
feature #23484 [DI] Remove remaining deprecated features (nicolas-gre…
fabpot Jul 12, 2017
e8b9e25
bug #23490 [DependencyInjection] non-conflicting anonymous service id…
fabpot Jul 12, 2017
de5c60d
minor #23492 [DI] Check privates before resolving alias in Container:…
nicolas-grekas Jul 13, 2017
f52a35c
Merge branch '3.4'
nicolas-grekas Jul 13, 2017
8cd1a2d
[Process] Fixed issue between process builder and exec
lyrixx Jul 13, 2017
5443599
bug #23498 [Process] Fixed issue between process builder and exec (ly…
nicolas-grekas Jul 13, 2017
8f6a0f7
[DI] Remove an unused property in the Compiler
dunglas Jul 14, 2017
6de81a7
[DI] Remove unused dynamic property
dunglas Jul 14, 2017
101b681
remove symfony/process suggestion
xabbuh Jul 15, 2017
d6534f5
[VarDumper] Added setMinDepth to VarCloner
james-johnston-thumbtack Jul 15, 2017
34e7094
[Profiler] Fix data collector getCasters() call
ogizanagi Jul 15, 2017
344c8bb
minor #23511 [DI] Remove an unused property in the Compiler (dunglas)
fabpot Jul 15, 2017
8dd172b
minor #23512 [DI] Remove unused dynamic property (dunglas)
fabpot Jul 15, 2017
3444d8d
minor #23514 [FrameworkBundle] remove symfony/process suggestion (xab…
fabpot Jul 15, 2017
de1143b
minor #23516 [Profiler] Fix data collector getCasters() call (ogizanagi)
nicolas-grekas Jul 15, 2017
b24a338
Merge branch '3.3' into 3.4
nicolas-grekas Jul 15, 2017
c725a70
[Profiler][Validator] ValidatorDataCollector: use new DataCollector::…
ogizanagi Jul 15, 2017
7ea2d04
[SecurityBundle] Clarify deprecation in UserPasswordEncoderCommand::g…
ro0NL Jul 15, 2017
bc6b57c
[WebServerBundle] remove duplicate code
fabpot Jul 16, 2017
34c8566
[WebServerBundle] allowed public/ root directory to be auto-discovere…
fabpot Jul 16, 2017
d1ce532
[Cache] add constructor docblocks for clarity
xabbuh Jul 14, 2017
b2c0dc3
[Stopwatch] Fix precision for root section
gharlan Jul 16, 2017
73c11a7
bug #23539 [Stopwatch] Fix precision for root section (gharlan)
nicolas-grekas Jul 17, 2017
0d72e82
minor #23523 [SecurityBundle] Clarify deprecation in UserPasswordEnco…
fabpot Jul 17, 2017
c75d0c5
bug #23535 Make server:* commands work out of the box with the public…
fabpot Jul 17, 2017
a6232a4
feature #23515 [VarDumper] Added setMinDepth to VarCloner (james-john…
fabpot Jul 17, 2017
aa27974
minor #23517 [Profiler][Validator] ValidatorDataCollector: use new Da…
fabpot Jul 17, 2017
9f96952
[DI] Removed deprecated setting private/pre-defined services
ro0NL May 20, 2017
1bdfe0b
[FrameworkBundle] Set default public directory on install assets
yceruto Jul 14, 2017
7beac82
bug #23513 [FrameworkBundle] Set default public directory on install …
fabpot Jul 17, 2017
286eb4d
feature #22801 [DI] Removed deprecated setting private/pre-defined se…
fabpot Jul 17, 2017
6ea71cb
[TwigBridge] deprecate TwigRenderer
Tobion Jul 6, 2017
80efd8f
minor #23505 [Cache] add constructor docblocks for clarity (xabbuh)
fabpot Jul 17, 2017
f25a8b5
Fix lazy commands registration
Jul 15, 2017
dd6fc4b
feature #23437 [TwigBridge] deprecate TwigRenderer (Tobion)
fabpot Jul 17, 2017
2fa948d
minor #23533 [Console] Application is not responsible for setting the…
fabpot Jul 17, 2017
649e2cd
Merge branch '3.2' into 3.3
fabpot Jul 17, 2017
1e88b35
Merge branch '3.3' into 3.4
fabpot Jul 17, 2017
46c7290
Merge branch '3.4'
nicolas-grekas Jul 17, 2017
26ffb95
Merge branch '3.2' into 3.3
fabpot Jul 17, 2017
2cc53ab
Merge branch '3.3' into 3.4
fabpot Jul 17, 2017
5baadb4
Merge branch '3.4'
fabpot Jul 17, 2017
7294781
fixed double-declaration
fabpot Jul 17, 2017
43eed76
Merge branch '3.3' into 3.4
fabpot Jul 17, 2017
09f196e
Merge branch '3.4'
fabpot Jul 17, 2017
7a608ef
updated CHANGELOG for 3.3.5
fabpot Jul 17, 2017
d7d9a07
updated VERSION for 3.3.5
fabpot Jul 17, 2017
b9a0d3d
Merge pull request #23555 from fabpot/release-3.3.5
fabpot Jul 17, 2017
5c2797a
bumped Symfony version to 3.3.6
fabpot Jul 17, 2017
37d8495
[DI] Minor dumping logic simplification
nicolas-grekas Jul 17, 2017
267970e
minor #23560 [DI] Minor dumping logic simplification (nicolas-grekas)
nicolas-grekas Jul 18, 2017
72aaecc
Merge branch '3.2' into 3.3
nicolas-grekas Jul 18, 2017
a0795c7
Merge branch '3.3' into 3.4
nicolas-grekas Jul 18, 2017
75701bc
Merge branch '3.4'
nicolas-grekas Jul 18, 2017
4917b30
fix merge
nicolas-grekas Jul 18, 2017
62410b6
[TwigBridge] fix tests
xabbuh Jul 18, 2017
ab661bd
minor #23567 [TwigBridge] fix tests (xabbuh)
fabpot Jul 18, 2017
aa90ce6
Merge branch '3.4'
nicolas-grekas Jul 18, 2017
aae494c
[TwigBridge] remove deprecated features
xabbuh May 19, 2017
aac9273
feature #22783 [TwigBridge] remove deprecated features (xabbuh)
nicolas-grekas Jul 18, 2017
c0af003
[FrameworkBundle] Make RouterCacheWarmer implement ServiceSubscriberI…
nicolas-grekas Jul 18, 2017
0bd1f09
remove useless comment
nicolas-grekas Jul 18, 2017
a1846f0
Merge branch '3.3' into 3.4
nicolas-grekas Jul 18, 2017
5a521bf
feature #23570 [FrameworkBundle] Make RouterCacheWarmer implement Ser…
fabpot Jul 18, 2017
4b30b6e
Merge branch '3.4'
nicolas-grekas Jul 18, 2017
e99b61c
Change "this" to "that" to avoid confusion
simshaun Jul 18, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Bridge/Twig/Command/LintCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ private function validate(Environment $twig, $template, $file)
} catch (Error $e) {
$twig->setLoader($realLoader);

return array('template' => $template, 'file' => $file, 'valid' => false, 'exception' => $e);
return array('template' => $template, 'file' => $file, 'line' => $e->getTemplateLine(), 'valid' => false, 'exception' => $e);
}

return array('template' => $template, 'file' => $file, 'valid' => true);
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Yaml/Command/LintCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ private function validate($content, $file = null)
{
$prevErrorHandler = set_error_handler(function ($level, $message, $file, $line) use (&$prevErrorHandler) {
if (E_USER_DEPRECATED === $level) {
throw new ParseException($message);
throw new ParseException($message, $this->getParser()->getLastLineNumberBeforeDeprecation());
}

return $prevErrorHandler ? $prevErrorHandler($level, $message, $file, $line) : false;
Expand All @@ -114,7 +114,7 @@ private function validate($content, $file = null)
try {
$this->getParser()->parse($content, Yaml::PARSE_CONSTANT);
} catch (ParseException $e) {
return array('file' => $file, 'valid' => false, 'message' => $e->getMessage());
return array('file' => $file, 'line' => $e->getParsedLine(), 'valid' => false, 'message' => $e->getMessage());
} finally {
restore_error_handler();
}
Expand Down
10 changes: 10 additions & 0 deletions src/Symfony/Component/Yaml/Parser.php
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,16 @@ public function parse($value, $flags = 0)
return $data;
}

/**
* @internal
*
* @return int
*/
public function getLastLineNumberBeforeDeprecation()
{
return $this->getRealCurrentLineNb();
}

private function doParse($value, $flags)
{
$this->currentLineNb = -1;
Expand Down
0