Make server:* commands work out of the box with the public/ root dir #23535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 17, 2017
fabpot
added a commit
that referenced
this pull request
Jul 17, 2017
…/ root dir (fabpot) This PR was squashed before being merged into the 3.3 branch (closes #23535). Discussion ---------- Make server:* commands work out of the box with the public/ root dir | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The first commit removes code that is not needed as the WebserverConfig class already throws the exact same error and the display is exactly the same in that case. The second commit adds support for `public/` along side `web/`. Commits ------- 34c8566 [WebServerBundle] allowed public/ root directory to be auto-discovered along side web/ bc6b57c [WebServerBundle] remove duplicate code
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes code that is not needed as the WebserverConfig class already throws the exact same error and the display is exactly the same in that case.
The second commit adds support for
public/along sideweb/.