10000 [HttpFoundation] Set meta refresh time to 0 in RedirectResponse content by jnvsor · Pull Request #23526 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Set meta refresh time to 0 in RedirectResponse content #23526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HttpFoundation] Set meta refresh time to 0 in RedirectResponse content #23526

wants to merge 1 commit into from

Conversation

jnvsor
Copy link
Contributor
@jnvsor jnvsor commented Jul 16, 2017
Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23524
License MIT

Set meta refresh time to 0 in RedirectResponse content

@ro0NL
Copy link
Contributor
ro0NL commented Jul 16, 2017

So is it a bugfix (2.7) or a new feature (3.4)? 2.7 seems fine or do you have legacy projects running onn 3.4? ;-)

@fabpot
Copy link
Member
fabpot commented Jul 16, 2017

I don't think this is worth it. What does it solve?

@jnvsor
Copy link
Contributor Author
jnvsor commented Jul 16, 2017

It removes the second-long white page with redirect notice if headers have already been sent. I'm not sure whether that's a bug or a feature, but it's an improvement either way I think.

@javiereguiluz
Copy link
Member

In theory, using 1 is a bug if we want to redirect immediately. MDN for example mentions this:

The content attribute starts with a number indicating how many seconds the browser should wait before redirecting to the given URL. Always set it to 0, for better accessibility.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Jul 17, 2017
@fabpot
Copy link
Member
fabpot commented Jul 17, 2017

Thank you @jnvsor.

fabpot added a commit that referenced this pull request Jul 17, 2017
@fabpot
bug #23526 [HttpFoundation] Set meta refresh time to 0 in RedirectRes…
d76171e 
…ponse content (jnvsor)

This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #23526).

Discussion
----------

[HttpFoundation] Set meta refresh time to 0 in RedirectResponse content

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23524
| License       | MIT

Set meta refresh time to 0 in RedirectResponse content

Commits
-------

5508a00 [HttpFoundation] Set meta refresh time to 0 in RedirectResponse content
@fabpot fabpot closed this Jul 17, 2017
This was referenced Jul 17, 2017
Merged
Merged
Merged
Merged
@emodric emodric mentioned this pull request Jul 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
HttpFoundation Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
6 participants
@jnvsor @ro0NL @fabpot @javiereguiluz @nicolas-grekas @carsonbot
0