8000 [DI] Handle root namespace in service definitions by ro0NL · Pull Request #23468 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] Handle root namespace in service definitions#23468

Closed
ro0NL wants to merge 2 commits intosymfony:2.7from
ro0NL:di/root-namespace
Closed

[DI] Handle root namespace in service definitions#23468
ro0NL wants to merge 2 commits intosymfony:2.7from
ro0NL:di/root-namespace

Conversation

@ro0NL
Copy link
Contributor
@ro0NL ro0NL commented Jul 10, 2017 •
edited
Loading
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Fixes

Cannot dump definition because of invalid class name ('\\stdClass')

for

services:
    foo: {class: '\stdClass' }

ContainerBuilder allows it, so PhpDumper should as well.

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Jul 11, 2017
stloyd
stloyd reviewed Jul 11, 2017
View reviewed changes
src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php Outdated
return '\\'.substr(str_replace('\\\\', '\\', $class), 1, -1);
$class = substr(str_replace('\\\\', '\\', $class), 1, -1);

return '\\' === substr($class, 0, 1) ? $class : '\\'.$class;
Copy link
Contributor
@stloyd stloyd Jul 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 === strpos($class, '\\')

@nicolas-grekas
Copy link
Member
nicolas-grekas commented Jul 12, 2017

Thank you @ro0NL.

nicolas-grekas added a commit that referenced this pull request Jul 12, 2017
@nicolas-grekas
bug #23468 [DI] Handle root namespace in service definitions (ro0NL)
87a6845 
This PR was squashed before being merged into the 2.7 branch (closes #23468).

Discussion
----------

[DI] Handle root namespace in service definitions

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Fixes

```
Cannot dump definition because of invalid class name ('\\stdClass')
```

for

```yaml
services:
    foo: {class: '\stdClass' }
```

`ContainerBuilder` allows it, so `PhpDumper` should as well.

Commits
-------

05170c8 [DI] Handle root namespace in service definitions
@ro0NL ro0NL deleted the di/root-namespace branch July 12, 2017 12:14
This was referenced Jul 17, 2017
Merged
Merged
Merged
Merged
@ro0NL ro0NL mentioned this pull request Sep 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot 7064 fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

+1 more reviewer

@stloyd stloyd stloyd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug DependencyInjection Status: Needs Review

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

5 participants

@ro0NL @nicolas-grekas @fabpot @stloyd @carsonbot
0