8000 [WebProfilerBundle] Remove deprecated TemplateManager::getTemplates() by maidmaid · Pull Request #23427 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[WebProfilerBundle] Remove deprecated TemplateManager::getTemplates() #23427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2017

Conversation

maidmaid
Copy link
Contributor
@maidmaid maidmaid commented Jul 6, 2017
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #20484
License MIT
Doc PR /

@fabpot
Copy link
Member
fabpot commented Jul 6, 2017

Thank you @maidmaid.

@fabpot fabpot merged commit f8be69d into symfony:master Jul 6, 2017
fabpot added a commit that referenced this pull request Jul 6, 2017
…etTemplates() (maidmaid)

This PR was merged into the 4.0-dev branch.

Discussion
----------

[WebProfilerBundle] Remove deprecated TemplateManager::getTemplates()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20484
| License       | MIT
| Doc PR        | /

Commits
-------

f8be69d Remove TemplateManager::getTemplates()
@maidmaid
Copy link
Contributor Author
maidmaid commented Jul 6, 2017

@fabpot In fact, do we need to trigger a deprecated message in 3.4? Or in this case, @deprecated annotation is enough?

@fabpot
Copy link
Member
fabpot commented Jul 6, 2017

This was done like this on purpose. So, nothing to do :)

@maidmaid maidmaid deleted the webprofiler-4 branch July 6, 2017 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0