10000 [Filesystem] Dont copy perms when origin is remote by nicolas-grekas · Pull Request #23398 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Filesystem] Dont copy perms when origin is remote #23398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2017
Merged

[Filesystem] Dont copy perms when origin is remote #23398

merged 1 commit into from
Jul 5, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23312
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Jul 5, 2017
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 5, 2017
Closed
@fabpot
Copy link
Member
fabpot commented Jul 5, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 7b44221 into symfony:2.7 Jul 5, 2017
fabpot added a commit that referenced this pull request Jul 5, 2017
@fabpot
bug #23398 [Filesystem] Dont copy perms when origin is remote (nicola…
311e627 
…s-grekas)

This PR was merged into the 2.7 branch.

Discussion
----------

[Filesystem] Dont copy perms when origin is remote

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23312
| License       | MIT
| Doc PR        | -

Commits
-------

7b44221 [Filesystem] Dont copy perms when origin is remote
@axzx
Copy link
Contributor
axzx commented Jul 11, 2017

what about branch 3.3?
8000

@nicolas-grekas nicolas-grekas deleted the fs-fix branch July 11, 2017 08:19
@xabbuh
Copy link
Member
xabbuh commented Jul 11, 2017

@axzx We regularly merge branches up. So this fix will eventually be part of all still maintained Symfony versions.

This was referenced Jul 17, 2017
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Filesystem Status: Reviewed
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolas-grekas @fabpot @axzx @xabbuh @carsonbot
0