[WebServer] Allow * to bind all interfaces (as INADDR_ANY) #23320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidmaid
reviewed
Jun 28, 2017
| $this->port = $this->findBestPort(); | ||
| } elseif (false !== $pos = strrpos($address, ':')) { | ||
| $this->hostname = substr($address, 0, $pos); | ||
| if ($this->hostname == '*') { |
Contributor
There was a problem hiding this comment.
'*' === $this->hostname instead?
Member
There was a problem hiding this comment.
Comparison must be strict indeed.
stof
requested changes
Jun 28, 2017
Member
There was a problem hiding this comment.
You also need to support * in the else clause when the port is not specified
| 3.4.0 | ||
| ----- | ||
|
|
||
| * 'WebServer can now use '*' as a wildcard to bind to 0.0.0.0 (INADDR_ANY) |
Member
There was a problem hiding this comment.
you have an extra quote at the beginning. and the value should use backticks to make it a Markdown code span (especially given that * is a special char otherwise)
| $this->port = $this->findBestPort(); | ||
| } elseif (false !== $pos = strrpos($address, ':')) { | ||
| $this->hostname = substr($address, 0, $pos); | ||
| if ($this->hostname == '*') { |
Member
There was a problem hiding this comment.
Comparison must be strict indeed.
fabpot
approved these changes
Jul 3, 2017
Member
|
Thank you @jpauli. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2017
…ANY) (jpauli, fabpot) This PR was merged into the 3.4 branch. Discussion ---------- [WebServer] Allow * to bind all interfaces (as INADDR_ANY) | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no-tests | Fixed tickets | ~ | License | MIT | Doc PR | In Python and elsewhere, binding to '*' means '0.0.0.0' (INADDR_ANY). I just added that to WebServer command. Commits ------- 1880bcf fixed CS b31ebae Allow * to bind all interfaces (as INADDR_ANY)
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python and elsewhere, binding to '*' means '0.0.0.0' (INADDR_ANY). I just added that to WebServer command.