8000 [Stopwatch] Add a reset method by jmgq · Pull Request #23285 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Stopwatch] Add a reset method #23285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Conversation

jmgq
Copy link
Contributor
@jmgq jmgq commented Jun 24, 2017
Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23284
License MIT
Doc PR symfony/symfony-docs#8082

Let the Stopwatch to be reset to its original state, deleting all the data measured so far. This allows the stopwatch to be reusable, and emulates an actual stopwatch's reset button.

Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've never needed this feature ... but it would probably make sense to add it. I'm almost +1 on this.

@fabpot
Copy link
Member
fabpot commented Jul 3, 2017

Thank you @jmgq.

@fabpot fabpot merged commit 7cda099 into symfony:3.4 Jul 3, 2017
fabpot added a commit that referenced this pull request Jul 3, 2017
This PR was merged into the 3.4 branch.

Discussion
----------

[Stopwatch] Add a reset method

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23284
| License       | MIT
| Doc PR        | symfony/symfony-docs#8082

Let the Stopwatch to be reset to its original state, deleting all the data measured so far. This allows the stopwatch to be reusable, and emulates an actual stopwatch's reset button.

Commits
-------

7cda099 [Stopwatch] Add a reset method
This was referenced Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0