symfony · fabpot · Sep 3, 2017 · Aug 5, 2017 · Jun 26, 2017 · jenkoian
diff --git a/src/Symfony/Bridge/Doctrine/Form/ChoiceList/IdReader.php b/src/Symfony/Bridge/Doctrine/Form/ChoiceList/IdReader.php
@@ -82,7 +82,7 @@ public function __construct(ObjectManager $om, ClassMetadata $classMetadata)
      * @return bool Returns `true` if the class has a single-column ID and
      *              `false` otherwise.
      */
-    public function isSingleId()
+    public function isSingleId(): bool
     {
         return $this->singleId;
     }
@@ -93,7 +93,7 @@ public function isSingleId()
      * @return bool Returns `true` if the class has a single-column integer ID
      *              and `false` otherwise.
      */
-    public function isIntId()
+    public function isIntId(): bool
     {
         return $this->intId;
     }
@@ -138,7 +138,7 @@ public function getIdValue($object)
      *
      * @return string The name of the ID field
      */
-    public function getIdField()
+    public function getIdField(): string
     {
         return $this->idField;
     }

diff --git a/src/Symfony/Bundle/SecurityBundle/Debug/WrappedListener.php b/src/Symfony/Bundle/SecurityBundle/Debug/WrappedListener.php
@@ -56,12 +56,12 @@ public function __call($method, $arguments)
         return call_user_func_array(array($this->listener, $method), $arguments);
     }
 
-    public function getWrappedListener()
+    public function getWrappedListener(): ListenerInterface
     {
         return $this->listener;
     }
 
-    public function getInfo()
+    public function getInfo(): array
     {
         if (null === $this->stub) {
             $this->stub = self::$hasVarDumper ? new ClassStub(get_class($this->listener)) : get_class($this->listener);

diff --git a/src/Symfony/Bundle/SecurityBundle/Security/FirewallConfig.php b/src/Symfony/Bundle/SecurityBundle/Security/FirewallConfig.php
@@ -29,21 +29,7 @@ final class FirewallConfig
     private $listeners;
     private $switchUser;
 
-    /**
-     * @param string      $name
-     * @param string      $userChecker
-     * @param string|null $requestMatcher
-     * @param bool        $securityEnabled
-     * @param bool        $stateless
-     * @param string|null $provider
-     * @param string|null $context
-     * @param string|null $entryPoint
-     * @param string|null $accessDeniedHandler
-     * @param string|null $accessDeniedUrl
-     * @param string[]    $listeners
-     * @param array|null  $switchUser
-     */
-    public function __construct($name, $userChecker, $requestMatcher = null, $securityEnabled = true, $stateless = false, $provider = null, $context = null, $entryPoint = null, $accessDeniedHandler = null, $accessDeniedUrl = null, $listeners = array(), $switchUser = null)
+    public function __construct(string $name, string $userChecker, string $requestMatcher = null, bool $securityEnabled = true, bool $stateless = false, string $provider = null, string $context = null, string $entryPoint = null, string $accessDeniedHandler = null, string $accessDeniedUrl = null, array $listeners = array(), $switchUser = null)
     {
         $this->name = $name;
         $this->userChecker = $userChecker;
@@ -59,7 +45,7 @@ public function __construct($name, $userChecker, $requestMatcher = null, $securi
         $this->switchUser = $switchUser;
     }
 
-    public function getName()
+    public function getName(): string
     {
         return $this->name;
     }
@@ -68,86 +54,65 @@ public function getName()
      * @return string|null The request matcher service id or null if neither the request matcher, pattern or host
      *                     options were provided
      */
-    public function getRequestMatcher()
+    public function getRequestMatcher(): ?string
     {
         return $this->requestMatcher;
     }
 
-    public function isSecurityEnabled()
+    public function isSecurityEnabled(): bool
     {
         return $this->securityEnabled;
     }
 
-    public function allowsAnonymous()
+    public function allowsAnonymous(): bool
     {
         return in_array('anonymous', $this->listeners, true);
     }
 
-    public function isStateless()
+    public function isStateless(): bool
     {
         return $this->stateless;
     }
 
-    /**
-     * @return string|null The provider service id
-     */
-    public function getProvider()
+    public function getProvider(): ?string
     {
         return $this->provider;
     }
 
     /**
      * @return string|null The context key (will be null if the firewall is stateless)
      */
-    public function getContext()
+    public function getContext(): ?string
     {
         return $this->context;
     }
 
-    /**
-     * @return string|null The entry_point service id if configured, null otherwise
-     */
-    public function getEntryPoint()
+    public function getEntryPoint(): ?string
     {
         return $this->entryPoint;
     }
 
-    /**
-     * @return string The user_checker service id
-     */
-    public function getUserChecker()
+    public function getUserChecker(): string
     {
         return $this->userChecker;
     }
 
-    /**
-     * @return string|null The access_denied_handler service id if configured, null otherwise
-     */
-    public function getAccessDeniedHandler()
+    public function getAccessDeniedHandler(): ?string
     {
         return $this->accessDeniedHandler;
     }
 
-    /**
-     * @return string|null The access_denied_handler URL if configured, null otherwise
-     */
-    public function getAccessDeniedUrl()
+    public function getAccessDeniedUrl(): ?string
     {
         return $this->accessDeniedUrl;
     }
 
-    /**
-     * @return string[] An array of listener keys
-     */
-    public function getListeners()
+    public function getListeners(): array
     {
         return $this->listeners;
     }
 
-    /**
-     * @return array|null The switch_user parameters if configured, null otherwise
-     */
-    public function getSwitchUser()
+    public function getSwitchUser(): ?array
     {
         return $this->switchUser;
     }

diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/Security/FirewallMapTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/Security/FirewallMapTest.php
@@ -18,7 +18,6 @@
 use Symfony\Component\DependencyInjection\Container;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\RequestMatcherInterface;
-use Symfony\Component\Security\Core\User\UserCheckerInterface;
 use Symfony\Component\Security\Http\Firewall\ExceptionListener;
 use Symfony\Component\Security\Http\Firewall\ListenerInterface;
 
@@ -63,7 +62,7 @@ public function testGetListeners()
 
         $firewallContext = $this->getMockBuilder(FirewallContext::class)->disableOriginalConstructor()->getMock();
 
-        $firewallConfig = new FirewallConfig('main', $this->getMockBuilder(UserCheckerInterface::class)->getMock());
+        $firewallConfig = new FirewallConfig('main', 'user_checker');
         $firewallContext->expects($this->once())->method('getConfig')->willReturn($firewallConfig);
 
         $listener = $this->getMockBuilder(ListenerInterface::class)->getMock();

diff --git a/src/Symfony/Component/Config/Loader/FileLoader.php b/src/Symfony/Component/Config/Loader/FileLoader.php
@@ -81,7 +81,7 @@ public function getLocator()
      * @throws FileLoaderImportCircularReferenceException
      * @throws FileLocatorFileNotFoundException
      */
-    public function import($resource, $type = null, $ignoreErrors = false, $sourceResource = null)
+    public function import($resource, $type = null, bool $ignoreErrors = false, $sourceResource = null)
     {
         if (is_string($resource) && strlen($resource) !== $i = strcspn($resource, '*?{[')) {
             $ret = array();
@@ -104,7 +104,7 @@ public function import($resource, $type = null, $ignoreErrors = false, $sourceRe
     /**
      * @internal
      */
-    protected function glob($pattern, $recursive, &$resource = null, $ignoreErrors = false)
+    protected function glob(string $pattern, bool $recursive, &$resource = null, bool $ignoreErrors = false)
     {
         if (strlen($pattern) === $i = strcspn($pattern, '*?{[')) {
             $prefix = $pattern;
@@ -138,7 +138,7 @@ protected function glob($pattern, $recursive, &$resource = null, $ignoreErrors =
         }
     }
 
-    private function doImport($resource, $type = null, $ignoreErrors = false, $sourceResource = null)
+    private function doImport($resource, $type = null, bool $ignoreErrors = false, $sourceResource = null)
     {
         try {
             $loader = $this->resolve($resource, $type);

diff --git a/src/Symfony/Component/Console/Event/ConsoleErrorEvent.php b/src/Symfony/Component/Console/Event/ConsoleErrorEvent.php
@@ -12,7 +12,6 @@
 namespace Symfony\Component\Console\Event;
 
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Exception\InvalidArgumentException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
@@ -26,57 +25,33 @@ final class ConsoleErrorEvent extends ConsoleEvent
     private $error;
     private $exitCode;
 
-    public function __construct(InputInterface $input, OutputInterface $output, $error, Command $command = null)
+    public function __construct(InputInterface $input, OutputInterface $output, \Throwable $error, Command $command = null)
     {
         parent::__construct($command, $input, $output);
 
-        $this->setError($error);
+        $this->error = $error;
     }
 
-    /**
-     * Returns the thrown error/exception.
-     *
-     * @return \Throwable
-     */
-    public function getError()
+    public function getError(): \Throwable
     {
         return $this->error;
     }
 
-    /**
-     * Replaces the thrown error/exception.
-     *
-     * @param \Throwable $error
-     */
-    public function setError($error)
+    public function setError(\Throwable $error): void
     {
-        if (!$error instanceof \Throwable && !$error instanceof \Exception) {
-            throw new InvalidArgumentException(sprintf('The error passed to ConsoleErrorEvent must be an instance of \Throwable or \Exception, "%s" was passed instead.', is_object($error) ? get_class($error) : gettype($error)));
-        }
-
         $this->error = $error;
     }
 
-    /**
-     * Sets the exit code.
-     *
-     * @param int $exitCode The command exit code
-     */
-    public function setExitCode($exitCode)
+    public function setExitCode(int $exitCode): void
     {
-        $this->exitCode = (int) $exitCode;
+        $this->exitCode = $exitCode;
 
         $r = new \ReflectionProperty($this->error, 'code');
         $r->setAccessible(true);
         $r->setValue($this->error, $this->exitCode);
     }
 
-    /**
-     * Gets the exit code.
-     *
-     * @return int The command exit code
-     */
-    public function getExitCode()
+    public function getExitCode(): int
     {
         return null !== $this->exitCode ? $this->exitCode : ($this->error->getCode() ?: 1);
     }