8000 [PropertyAccess] Fix Usage with anonymous classes by mablae · Pull Request #23156 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyAccess] Fix Usage with anonymous classes #23156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2017
Merged

[PropertyAccess] Fix Usage with anonymous classes #23156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Usage with anonymous classes 
Replace forbidden characters in the the class names of Anonymous Classes in form of
"class@anonymous /symfony/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php0x7f3f5f267ad5"

Wrapped in eval to avoid PHP parsing errors < 7
  • Loading branch information
@mablae
mablae committed Jun 13, 2017
commit 3f7fd432dfb3a2e3ab92b1681d6ec25a32cd1574
4 changes: 2 additions & 2 deletions src/Symfony/Component/PropertyAccess/PropertyAccessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ private function readProperty($zval, $property)
*/
private function getReadAccessInfo($class, $property)
{
$key = $class.'..'.$property;
$key = (false !== strpos($class, '@') ? rawurlencode($class) : $class).'..'.$property;

if (isset($this->readPropertyCache[$key])) {
return $this->readPropertyCache[$key];
Expand Down Expand Up @@ -702,7 +702,7 @@ private function writeCollection($zval, $property, $collection, $addMethod, $rem
*/
private function getWriteAccessInfo($class, $property, $value)
{
$key = $class.'..'.$property;
$key = (false !== strpos($class, '@') ? rawurlencode($class) : $class).'..'.$property;

if (isset($this->writePropertyCache[$key])) {
return $this->writePropertyCache[$key];
Expand Down
60 changes: 60 additions & 0 deletions src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,4 +578,64 @@ public function testThrowTypeErrorWithInterface()

$this->propertyAccessor->setValue($object, 'countable', 'This is a string, \Countable expected.');
}

/**
* @requires PHP 7.0
*/
public function testAnonymousClassRead()
{
$value = 'bar';

$obj = $this->generateAnonymousClass($value);

$propertyAccessor = new PropertyAccessor(false, false, new ArrayAdapter());

$this->assertEquals($value, $propertyAccessor->getValue($obj, 'foo'));
}

/**
* @requires PHP 7.0
*/
public function testAnonymousClassWrite()
{
$value = 'bar';

$obj = $this->generateAnonymousClass('');

$propertyAccessor = new PropertyAccessor(false, false, new ArrayAdapter());
$propertyAccessor->setValue($obj, 'foo', $value);

$this->assertEquals($value, $propertyAccessor->getValue($obj, 'foo'));
}

private function generateAnonymousClass($value)
{
$obj = eval('return new class($value)
{
private $foo;

public function __construct($foo)
{
$this->foo = $foo;
}

/**
* @return mixed
*/
public function getFoo()
{
return $this->foo;
}

/**
* @param mixed $foo
*/
public function setFoo($foo)
{
$this->foo = $foo;
}
};');

return $obj;
}
}
0