-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
{{ message }}
[FrameworkBundle] Fix perf issue in CacheClearCommand::warmup() #23086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR is related to my specific case where upgrading to 3.3 in one of our apps makes it unusable in @nicolas-grekas can view those profiles. |
Contributor
|
Without additional |
fabpot
approved these changes
Jun 9, 2017
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2017
…mup() (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Fix perf issue in CacheClearCommand::warmup() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - On slow file systems (eg on Windows), I noticed that writing files without doing any changes just kills perf. Limiting the depth also helps when the symfony/cache component is used (because it can store thousands of files in its cache pool directory structure, and iterating there is also a waste of *fs* time). I choose the max depth by looking at where existing apps put their files and added one level more just in case. Commits ------- b58f060 [FrameworkBundle] Fix perf issue in CacheClearCommand::warmup()
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On slow file systems (eg on Windows), I noticed that writing files without doing any changes just kills perf.
Limiting the depth also helps when the symfony/cache component is used (because it can store thousands of files in its cache pool directory structure, and iterating there is also a waste of fs time).
I choose the max depth by looking at where existing apps put their files and added one level more just in case.