minor #23043 add \ to PHP_VERSION_ID fixes #22650 #23043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ | |||
| error_reporting(-1); | |||
|
|
|||
| // PHPUnit 4.8 does not support PHP 7, while 5.1 requires PHP 5.6+ | |||
| $PHPUNIT_VERSION = PHP_VERSION_ID >= 50600 ? getenv('SYMFONY_PHPUNIT_VERSION') ?: '5.7' : '4.8'; | |||
| $PHPUNIT_VERSION = \PHP_VERSION_ID >= 50600 ? getenv('SYMFONY_PHPUNIT_VERSION') ?: '5.7' : '4.8'; | |||
There was a problem hiding this comment.
root namespace, no need here
|
fixed |
xabbuh
approved these changes
Jun 2, 2017
|
Good catch, thanks @vincentaubert. |
fabpot
pushed a commit
that referenced
this pull request
Jun 2, 2017
fabpot
added a commit
that referenced
this pull request
Jun 2, 2017
…ntaubert) This PR was squashed before being merged into the 3.3 branch (closes #23043). Discussion ---------- minor #23043 add \ to PHP_VERSION_ID fixes #22650 | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22650 | License | MIT | Doc PR | n/a this PR is the last one fixing the \ before PHP_VERSION_ID closes definitively #22650 Commits ------- d3e6a2d minor #23043 add \ to PHP_VERSION_ID fixes #22650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is the last one fixing the \ before PHP_VERSION_ID closes definitively #22650