[Validator] Removes exception when validating non-traversable value with Composite constraints #23040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mposite constraints
|
Is it really just on 2.8, or does 2.7 have the same issue? |
|
One thought I had was to catch the |
|
It seems to be the most convenient way to do it, but don't we lose the property path information for this violation ? And by doing so we can't customize the error message easily (as it won't be bound to a constraint anymore). |
|
I'm closing because the PR is old and another approach is needed per the discussion. Feel free to resubmit of course. Thanks for the proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve a problem (might be considered a bug) we encountered when validating some API input.
As stated in the related issue, when validating a value that is not an array-like type against a composite constraint (either All or Collection), we get an exception.
This obviously does not cause much harm when used with the Form component where you control the data structure but is quite an issue when you must validate freely formatted content.
One of the obvious solution would have been to add a Type Constraint together with the Composite constraint but the constraints not being lazy executed, the exception is thrown anyway.