8000 [DoctrineBridge][PropertyInfo] Added support for Doctrine Embeddables by vudaltsov · Pull Request #23023 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[DoctrineBridge][PropertyInfo] Added support for Doctrine Embeddables #23023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Corrected test methods names and added markTestSkipped()
  • Loading branch information
vudaltsov committed Jun 2, 2017
commit d572d53098272a4ec84a14652d63ca2685155c12
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ public function testGetProperties()
);
}

public function testGetEmbeddableProperties()
public function testGetPropertiesWithEmbedded()
{
if (!class_exists('Doctrine\ORM\Mapping\Embedded')) {
return;
$this->markTestSkipped('@Embedded is not available in Doctrine ORM lower than 2.5.');
}

$this->assertEquals(
Expand All @@ -85,10 +85,10 @@ public function testExtract($property, array $type = null)
$this->assertEquals($type, $this->extractor->getTypes('Symfony\Bridge\Doctrine\Tests\PropertyInfo\Fixtures\DoctrineDummy', $property, array()));
}

public function testExtractEmbeddable()
public function testExtractWithEmbedded()
{
if (!class_exists('Doctrine\ORM\Mapping\Embedded')) {
return;
$this->markTestSkipped('@Embedded is not available in Doctrine ORM lower than 2.5.');
}

$expectedTypes = array(new Type(
Expand Down
0