[DI] Autowiring exception thrown when inlined service is removed #22993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exception to be thrown
3375e6b to
dd82f76
Compare
|
Second commit actually removes the |
nicolas-grekas
approved these changes
May 31, 2017
fabpot
approved these changes
May 31, 2017
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
May 31, 2017
…emoved (weaverryan) This PR was squashed before being merged into the 3.3 branch (closes #22993). Discussion ---------- [DI] Autowiring exception thrown when inlined service is removed | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | yes (on a new & internal method) | Tests pass? | yes | Fixed tickets | #22977 | License | MIT | Doc PR | n/a We suppress autowiring exceptions if a service is ultimately removed from the container. This fixes a bug where we incorrectly report that a service was NOT removed, when really, it WAS removed. This happens when `ServiceA` is inlined in `ServiceB`... but then `ServiceB` is removed from the container for being unused. Commits ------- 793b9a0 [DI] Autowiring exception thrown when inlined service is removed
stof
approved these changes
May 31, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We suppress autowiring exceptions if a service is ultimately removed from the container. This fixes a bug where we incorrectly report that a service was NOT removed, when really, it WAS removed. This happens when
ServiceAis inlined inServiceB... but thenServiceBis removed from the container for being unused.