8000 [SecurityBundle] Move cache of the firewall context into the request parameters by GromNaN · Pull Request #22943 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] Move cache of the firewall context into the request parameters #22943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SecurityBundle] Move cache of the firewall context into the request parameters #22943

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffaceb1
Move cache of the firewall context into the request parameters
GromNaN May 29, 2017
86bae5a
Fix test for Symfony 3.2, code was written for Symfony 3.4
GromNaN Jun 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test for Symfony 3.2, code was written for Symfony 3.4
  • Loading branch information
@GromNaN
GromNaN committed Jun 10, 2017
commit 86bae5ae3c567d288ed02a4d50b5355a8131368a
3 changes: 1 addition & 2 deletions src/Symfony/Bundle/SecurityBundle/Tests/Security/FirewallMapTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ public function testGetListeners()

$firewallContext = $this->getMockBuilder(FirewallContext::class)->disableOriginalConstructor()->getMock();
$firewallContext->expects($this->once())->method('getConfig')->willReturn('CONFIG');
$firewallContext->expects($this->once())->method('getListeners')->willReturn('LISTENERS');
$firewallContext->expects($this->once())->method('getExceptionListener')->willReturn('EXCEPTION LISTENER');
$firewallContext->expects($this->once())->method('getContext')->willReturn(array('LISTENERS', 'EXCEPTION LISTENER'));
Copy link
Member Author
@GromNaN GromNaN Jun 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging into 3.3, getContext is replaced by getListeners and getExceptionListener, update this line to:

$firewallContext->expects($this->once())->method('getListeners')->willReturn('LISTENERS');
$firewallContext->expects($this->once())->method('getExceptionListener')->willReturn('EXCEPTION LISTENER');

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks


$matcher = $this->getMockBuilder(RequestMatcherInterface::class)->getMock();
$matcher->expects($this->once())
Expand Down
0