[Form] fix guesed value param type in docblock #22939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
ro0NL
reviewed
May 29, 2017
| * @param string $value The guessed value | ||
| * @param int $confidence The confidence that the guessed class name | ||
| * is correct | ||
| * @param string|int|bool $value The guessed value |
There was a problem hiding this comment.
null value spotted as well :) https://github.com/symfony/symfony/blob/v3.2.8/src/Symfony/Bridge/Doctrine/Form/DoctrineOrmTypeGuesser.php#L135
Cant we allow scalar|null?
c094eb5 to
8b22563
Compare
ro0NL
reviewed
May 29, 2017
| @@ -42,7 +37,7 @@ public function __construct($value, $confidence) | |||
| /** | |||
| * Returns the guessed value. | |||
| * | |||
| * @return mixed | |||
| * @return string|int|bool | |||
8b22563 to
43636ba
Compare
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
May 29, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Form] fix guesed value param type in docblock | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 43636ba [Form] fix guesed value param type in docblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.