[Filesystem] improve error handling in lock() #22910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #22882 |
| License | MIT |
| Doc PR |
| } | ||
|
|
||
| if (!$e instanceof IOException) { | ||
| $this->fail(sprintf('Expected IOException to be thrown, got %s instead.', get_class($e))); |
There was a problem hiding this comment.
is this required if we remove the two last "catch"?
| $this->fail(sprintf('Expected IOException to be thrown, got %s instead.', get_class($e))); | ||
| } | ||
|
|
||
| if (null !== $wrongMessage) { |
| @@ -82,8 +86,12 @@ public function lock($blocking = false) | |||
| restore_error_handler(); | |||
|
|
|||
| if (!$this->handle) { | |||
| $error = error_get_last(); | |||
| throw new IOException($error['message'], 0, null, $this->file); | |||
| if (null === $error) { | |||
There was a problem hiding this comment.
is this possible at all? to me it shouldn't
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
May 28, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [Filesystem] improve error handling in lock() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22882 | License | MIT | Doc PR | Commits ------- 25381a2 [Filesystem] improve error handling in lock()
This was referenced May 29, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.