8000 [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const by nicolas-grekas · Pull Request #22904 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const #22904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2017
Merged

[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const #22904

merged 1 commit into from
May 25, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 3.3
Bug fix? yes (a missing part of a 3.3 feat.)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

See symfony/symfony-docs#7045

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone May 25, 2017
@nicolas-grekas nicolas-grekas mentioned this pull request May 25, 2017
Closed
@nicolas-grekas
Copy link
Member Author
nicolas-grekas commented May 25, 2017 •
edited
Loading

Can we ignore fabbot report here? Alignment is desired to me...

xabbuh
xabbuh approved these changes May 25, 2017
View reviewed changes
Copy link
Member
@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we prefer to use the binary format, I am in favour of keep the alignment to ease readability.

@javiereguiluz
Copy link
Member

I don't think we should keep the alignment. If we apply some code formatting syntax, we should apply it always and without exceptions. Otherwise this will cause problems when running the php-cs-fixer in the entire codebase, which is done from time to time.

@nicolas-grekas
Copy link
Member Author

ok, fabbot green

@nicolas-grekas nicolas-grekas changed the title [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS const [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const May 25, 2017
@nicolas-grekas
Copy link
Member Author

Just renamed the const to be even more explicit: Request::HEADER_X_FORWARDED_AWS_ELB

@nicolas-grekas nicolas-grekas mentioned this pull request May 25, 2017
Closed
@weaverryan
Copy link
Member

👍 This will help the docs - it's already complex enough :)

@fabpot
Copy link
Member
fabpot commented May 25, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 9ba12b0 into symfony:3.3 May 25, 2017
fabpot added a commit that referenced this pull request May 25, 2017
@fabpot
feature #22904 [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_E…
fa93ff1 
…LB const (nicolas-grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes (a missing part of a 3.3 feat.)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See symfony/symfony-docs#7045

Commits
-------

9ba12b0 [HttpFoundation] Add Request::HEADER_X_FORWARDED_AWS_ELB const
@nicolas-grekas nicolas-grekas deleted the req-x branch May 29, 2017 07:35
@fabpot fabpot mentioned this pull request May 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Needs Review
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @javiereguiluz @weaverryan @fabpot @xabbuh @carsonbot
0