8000 [FrameworkBundle] Handle project dir in cache:clear command by nicolas-grekas · Pull Request #22872 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Handle project dir in cache:clear command #22872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2017
Merged

[FrameworkBundle] Handle project dir in cache:clear command #22872

merged 1 commit into from
May 23, 2017

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22721
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone May 23, 2017
@nicolas-grekas nicolas-grekas mentioned this pull request May 23, 2017
Closed
@chalasr
Copy link
Member
chalasr commented May 23, 2017

It fixes it 👍
Status: reviewed

@fabpot
Copy link
Member
fabpot commented May 23, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit fadffad into symfony:3.3 May 23, 2017
fabpot added a commit that referenced this pull request May 23, 2017
@fabpot
bug #22872 [FrameworkBundle] Handle project dir in cache:clear comman…
aef39bc 
…d (nicolas-grekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Handle project dir in cache:clear command

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22721
| License       | MIT
| Doc PR        | -

Commits
-------

fadffad [FrameworkBundle] Handle project dir in cache:clear command
@jvasseur jvasseur mentioned this pull request May 24, 2017
Closed
@nicolas-grekas nicolas-grekas deleted the fix-warmup branch May 24, 2017 16:39
@aschempp aschempp mentioned this pull request May 26, 2017
Merged
fabpot added a commit that referenced this pull request May 26, 2017
@fabpot
bug #22921 [FrameworkBundle] Only override getProjectDir if it exists…
c69c539 
… in the kernel (aschempp)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] Only override getProjectDir if it exists in the kernel

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22872, #2289
| License       | MIT
| Doc PR        | -

As discussed with @nicolas-grekas, the `getProjectDir` method does not belong to `KernelInterface` so it can't just be called. I think we should also not add the method to the kernel if it does not exist in the parent, because we would not have a useful value to return.

Commits
-------

c7ed08e Only override getProjectDir if it exists in the kernel
@fabpot fabpot mentioned this pull request May 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @chalasr @fabpot @carsonbot
0