CS Fixes #22844
Merged
CS Fixes #22844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
ogizanagi
approved these changes
May 22, 2017
xabbuh
approved these changes
May 22, 2017
|
travis random failure unrelated |
| @@ -197,7 +197,6 @@ public function doRun(InputInterface $input, OutputInterface $output) | |||
| $e = $this->runningCommand = null; | |||
| // the command name MUST be the first element of the input | |||
| $command = $this->find($name); | |||
| } catch (\Exception $e) { | |||
| } catch (\Throwable $e) { | |||
| } | |||
| if (null !== $e) { | |||
There was a problem hiding this comment.
then this if is useless (and the initialization of $e also)
| @@ -813,7 +812,6 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI | |||
| } else { | |||
| $exitCode = ConsoleCommandEvent::RETURN_CODE_DISABLED; | |||
| } | |||
| } catch (\Exception $e) { | |||
| } catch (\Throwable $e) { | |||
| } | |||
| if (null !== $e) { | |||
There was a problem hiding this comment.
same (init + if can be removed)
chalasr
commented
May 22, 2017
| @@ -88,7 +52,7 @@ private function getType(\ReflectionParameter $parameter) | |||
| if (!$type = $parameter->getType()) { | |||
| return; | |||
| } | |||
| $typeName = $type instanceof \ReflectionNamedType ? $type->getName() : $type->__toString(); | |||
There was a problem hiding this comment.
ReflectionType::__toString() is deprecated
There was a problem hiding this comment.
right - and there are more of it in the code base, isn't it?
There was a problem hiding this comment.
indeed, all fixed. addressed your other comments also
b0cf180 to
832d490
Compare
| @@ -51,7 +51,6 @@ public static function castClosure(\Closure $c, array $a, Stub $stub, $isNested, | |||
| unset($v->value['position'], $v->value['isVariadic'], $v->value['byReference'], $v); | |||
| } | |||
| } | |||
| ; | |||
There was a problem hiding this comment.
me either, applied fabbot patch blindly. reverted
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- CS Fixes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 21114f8 CS Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.