8000 [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator by ogizanagi · Pull Request #22808 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator #22808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2017
Merged

[FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator #22808

merged 1 commit into from
May 23, 2017

Conversation

ogizanagi
Copy link
Contributor
@ogizanagi ogizanagi commented May 20, 2017 •
edited
Loading
Q A
Branch? 3.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #22800 (comment)
License MIT
Doc PR N/A

@ogizanagi ogizanagi mentioned this pull request May 20, 2017
Merged
@nicolas-grekas nicolas-grekas modified the milestone: 3.4 May 21, 2017
@chalasr
Copy link
Member
chalasr commented May 21, 2017

This just tweaks #21730, I would do it on 3.3 if doable (to avoid a second upgrade path on the next minor for the same code area). Anyway this looks good to me

@ogizanagi
Copy link
Contributor Author

@nicolas-grekas : What do you think about this one? Keeping it for 3.4, or re-targeting to 3.3?

@nicolas-grekas
Copy link
Member

Let's go for 3.3

@ogizanagi ogizanagi changed the base branch from 3.4 to 3.3 May 21, 2017 12:32
@ogizanagi
Copy link
Contributor Author

Re-targeted.

@nicolas-grekas
Copy link
Member

test fail, typo in error deprecation message

@nicolas-grekas nicolas-grekas modified the milestones: 3.3, 3.4 May 21, 2017
@ogizanagi
Copy link
Contributor Author

Fixed.

nicolas-grekas
nicolas-grekas approved these changes May 22, 2017
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit df747ce into symfony:3.3 May 23, 2017
nicolas-grekas added a commit that referenced this pull request May 23, 2017
@nicolas-grekas
feature #22808 [FrameworkBundle][Validator] Deprecate passing validat…
4a76669 
…or instances/aliases over using the service locator (ogizanagi)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator

| Q             | A
| ------------- | ---
| Branch?       | 3.3 <!-- see comment below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #22800 (comment) <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

df747ce [FrameworkBundle][Validator] Deprecate passing validator instances/aliases over using the service locator
@ogizanagi ogizanagi deleted the deprec/3.4/fwb/constraint_validator_factory_2nd_arg branch May 23, 2017 09:03
@ogizanagi ogizanagi mentioned this pull request May 24, 2017
Closed
@fabpot fabpot mentioned this pull request May 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Deprecation FrameworkBundle Status: Needs Review Validator
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
5 participants
@ogizanagi @chalasr @nicolas-grekas @xabbuh @carsonbot
0