[Intl] [ResourceBundle] refactor LanguageBundle #22798
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he locator should be injected
* 2.7: Make .travis.yml more readable Fold Travis CI output by component Add trhows PHPDoc in Application::run [Debug] Set exit status to 255 on error [HttpFoundation] Store IANA's RNG files in the repository [HttpFoundation] Fix getClientIp @return docblock Add @throws phpdoc unify PHPUnit config files
* 2.8: Make .travis.yml more readable Fold Travis CI output by component Add trhows PHPDoc in Application::run [Debug] Set exit status to 255 on error [HttpFoundation] Store IANA's RNG files in the repository [PropertyInfo] Remove a useless call to count() in SerializerExtractor [PropertyInfo] Prevent returning int values in some cases. [HttpFoundation] Fix getClientIp @return docblock Add @throws phpdoc unify PHPUnit config files
* 3.2: Make .travis.yml more readable Fold Travis CI output by component [VarDumper] Minor tweaks to html/css dumps Add trhows PHPDoc in Application::run [Debug] Set exit status to 255 on error [HttpFoundation] Store IANA's RNG files in the repository [PropertyInfo] Remove a useless call to count() in SerializerExtractor [PropertyInfo] Prevent returning int values in some cases. [HttpFoundation] Fix getClientIp @return docblock Add @throws phpdoc unify PHPUnit config files
* 3.2: fix merge
…ut command (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [Console] Fix fatal error when logging console.error without command | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22449 | License | MIT | Doc PR | n/a Happens now that the console.error event is dispatched on command not found, I ran into using `server:run` on 3.3 without `web-server-bundle` enabled: > PHP Fatal error: Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to a member function getName() on null In this case, this first tries to cast the event input as string (less good than when the command name is available, there're extra quotes around the command name) and, if can't be casted, uses a generic message. Commits ------- 97129fc Fix fatal error when logging console.error without a command
The conflict rule already forbids installing releases before 3.3 of the Asset component. This will bring the constraint in the `require-dev` section inline with the conflict rule.
…nent (xabbuh) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] clarify constraint for the Asset component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The conflict rule already forbids installing releases before 3.3 of the Asset component. This will bring the constraint in the `require-dev` section inline with the conflict rule. Commits ------- 35fe02f clarify constraint for the Asset component
… (zelazowy) This PR was merged into the 3.3-dev branch. Discussion ---------- Fixed formatting in Security section (in UPGRADE-3.0.md) | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no Added space (yeah...) to Security section fixing text and code format. Commits ------- 3bde16c Fixed formatting in Security section
…-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Reduce memory overhead of id normalization | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 1dd3285 [DI] Reduce memory overhead of id normalization
…r (ScullWM, nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- Persist app bootstrapping logs for logger datacollector | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | yes | BC breaks? | ? | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21405 | License | MIT Logs generated during the container build are catched by the BufferingLogger with a special flag. They are persist by the LoggerDataCollector and are available in the logger profiler. In the profiler toolbar, the "container build" logs increment the current logs counter (even if the container was previously built). <img width="540" alt="capture d ecran 2017-02-01 a 20 56 40" src="https://cloud.githubusercontent.com/assets/1017746/22523826/0bc12e4a-e8c1-11e6-830f-7f6238ea7423.png"> <img width="1022" alt="capture d ecran 2017-02-01 a 20 57 55" src="https://cloud.githubusercontent.com/assets/1017746/22523859/2c48a698-e8c1-11e6-9bdb-d85f3e692938.png"> The BufferingLogger now require the cachePath and the filesystem to persist a (unique) container build logs. If the current workflow is ok, I will update the test coverage (actually they fail). Maybe we can display the appDevDebugProjectContainerCompiler.log content in that logger profile. Commits ------- 2fd18b5 [VarDumper] Fine tune dumping log messages ce3ef6a Persist app bootstrapping logs for logger datacollector
…configuration (weaverryan) This PR was squashed before being merged into the 3.3-dev branch (closes #22234). Discussion ---------- [DI] Introducing autoconfigure: automatic _instanceof configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes (mostly, a continuation of a new feature) | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#7538 This is a proposal to allow the user to opt into some automatic `_instanceof` config. Suppose I want to auto-tag all of my voters and event subscribers ```yml # current services: _defaults: autowire: true _instanceof: Symfony\Component\Security\Core\Authorization\Voter\VoterInterface: tags: [security.voter] Symfony\Component\EventDispatcher\EventSubscriberInterface: tags: [kernel.event_subscriber] # services using the above tags AppBundle\Security\PostVoter: ~ AppBundle\EventListener\CheckRequirementsSubscriber: ~ ``` If I'm registering a service with a class that implements `VoterInterface`, when would I ever *not* want that to be tagged with `security.voter`? Here's the proposed code: ```yml # proposed services: _defaults: autowire: true autoconfigure: true # services using the auto_configure_instanceof functionality AppBundle\Security\PostVoter: ~ AppBundle\EventListener\CheckRequirementsSubscriber: ~ ``` The user must opt into this and it only applies locally to this configuration file. It works because each enabled bundle would have the opportunity to add one or more "automatic instanceof" definitions - e.g. SecurityBundle would add the `security.voter` instanceof config, FrameworkBundle would add the `kernel.event_subscriber` instanceof config, etc. For another example, you can check out the proposed changes to `symfony-demo` - symfony/demo#483 - the `_instanceof` section is pretty heavy: https://github.com/hhamon/symfony-demo/blob/81694ac21e63bebe7ecfa22fa689766f2f38ccd5/app/config/services.yml#L20 Thanks! Commits ------- 18627bf [DI] Introducing autoconfigure: automatic _instanceof configuration
This PR was merged into the 3.3-dev branch. Discussion ---------- [HttpKernel] sync upgrade files | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22315 | License | MIT | Doc PR | Commits ------- a90e461 sync upgrade files
…iereguiluz) This PR was merged into the 3.3-dev branch. Discussion ---------- Fixed the rendering of exceptions inside the profiler | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22442 | License | MIT | Doc PR | - In #22448 we tried to reuse the same CSS styles as the new exception pages. But that's not enough because it doesn't look good:  --- This PR goes a bit further and tweaks the exception styles slightly to better integrate them. Same page as before:  It should also work reasonably well when the exception message is very long:  Commits ------- 73d81de Fixed the rendering of exceptions inside the profiler
… (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [Security] Fix json_login default success/failure handling | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no (master only) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22483 | License | MIT | Doc PR | n/a This makes the `json_login` listener default configuration stateless oriented by: - Not using the default (redirect based) failure handler, it returns a 401 (json) response containing the failure reason instead - Not using the default (redirect based) success handler, just let the original request continue instead (reaching the targeted resource without being redirected). - Setting `require_previous_session` to `false` by default (I have to set it on `form-login` each time I want it to be stateless) - Removing the options related to redirections (`default_target_path`, `login_path`, ...) from the listener factory, if one wants redirections then one has to write its own handlers, not the inverse Commits ------- 9749618 Fix json_login default success/failure handling
… to Reference[] (nicolas-grekas) This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Fix inlining conflict by restricting IteratorArgument to Reference[] | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - `Reference` found in `ArgumentInterface::getValue()` are currently not inlined. While trying to do so (hint: I failed), I noticed that the current code is broken for `IteratorArgument` which can contain anonymous `Definition` for now, which are then not inlined correctly. This PR restricts `IteratorArgument` to arrays of `Reference`, and improves a few related things found while doing it. (fabbot failure is false positive) Commits ------- 4d3dce1 [DI] Fix inlining conflict by restricting IteratorArgument to Reference[]
* 3.4: Allow individual bridges, bundles and components to be used with 4.0
… dunglas, nicolas-grekas) This PR was merged into the 4.0-dev branch. Discussion ---------- Bump minimum version to PHP 7.1 for Symfony 4 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes-ish? | BC breaks? | yes-ish? | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 4758c2c Tweak travis and appveyor for Symfony 4 6633c8b Allow individual bridges, bundles and components to be used with 4.0 c850733 bumped minimum version to PHP 7.1
…s (javiereguiluz) This PR was merged into the 2.8 branch. Discussion ---------- Improved how profiler errors are displayed on small screens | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This change only affects the profiler menu when displaying it on small screens and collapsed: | BEFORE | AFTER | --- | --- |  |  In action:  Commits ------- 3d6d80d Improved how profiler errors are dispalyed on small screens
…dunglas) This PR was merged into the 4.0-dev branch. Discussion ---------- [Serializer] Remove deprecated DoctrineCache support | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- be951b7 [Serializer] Remove deprecated DoctrineCache support
* 2.7: CI fixes
* 2.8: CI fixes Improved how profiler errors are dispalyed on small screens
* 2.7: typo
* 2.8: typo
* 3.2: typo CI fixes Improved how profiler errors are dispalyed on small screens
* 3.3: typo CI fixes Improved how profiler errors are dispalyed on small screens bumped Symfony version to 3.3.0 updated VERSION for 3.3.0-RC1 updated CHANGELOG for 3.3.0-RC1
* 3.4: typo CI fixes Improved how profiler errors are dispalyed on small screens bumped Symfony version to 3.3.0 updated VERSION for 3.3.0-RC1 updated CHANGELOG for 3.3.0-RC1
… second parameter
…tion entries is `state_machine`
This PR was squashed before being merged into the 4.0-dev branch (closes #22771). Discussion ---------- [Workflow] Removed deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a --- Note: all commits are atomic Commits ------- 3bed8f6 [Workflow] The `type` option of the `framework.workflows.*` configuration entries is `state_machine` fd25777 [Workflow] Removed FrameworkBundle/DependencyInjection/Compiler/ValidateWorkflowsPass 1ccbe0b [Workflow] Removed class name support in `WorkflowRegistry::add()` as second parameter
…n (nicolas-grekas) This PR was merged into the 4.0-dev branch. Discussion ---------- [Debug][VarDumper] Remove the symfony_debug C extension | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- f9c51a6 [Debug][VarDumper] Remove the symfony_debug C extension
|
First contribution enjoy! |
|
Can you update the base branch of your PR to master? The diff includes 2.7-master currently ;-) |
ro0NL
reviewed
May 20, 2017
| @@ -81,7 +81,7 @@ public function getLanguageNames($displayLocale = null) | |||
| try { | |||
| return $this->getNames($displayLocale); | |||
| } catch (MissingResourceException $e) { | |||
| return array(); | |||
| return []; | |||
There was a problem hiding this comment.
SF dont use this syntax (yet); so for consistency it's better to this all at once, or on a per-component base.
There was a problem hiding this comment.
Ok thanks, so i close this PR
There was a problem hiding this comment.
Guess so 👍 thx for taking time though :)
ro0NL
reviewed
May 20, 2017
CHANGELOG-3.0.md
Outdated
| @@ -55,7 +55,7 @@ To get the diff between two versions, go to https://github.com/symfony/symfony/c | |||
| * bug #19127 [Form] Add exception to FormRenderer about non-unique block names (enumag) | |||
| * bug #19118 [Process] Fix pipes cleaning on Windows (nicolas-grekas) | |||
| * bug #19128 Avoid phpunit 5.4 warnings on getMock (2.7+) (iltar) | |||
| * bug #19114 [HttpKernel] Dont close the reponse stream in debug (nicolas-grekas) | |||
| * bug #19114 [HttpKernel] Dont close the response stream in debug (nicolas-grekas) | |||
There was a problem hiding this comment.
These file are auto-generated on release, the typo comes from the PR actually ;-) see #19114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.